Re: [PATCH v3 1/2] mtd: cfi: respect reg address length

["Nuno Sá" <noname.nuno@gmail.com>]

Hi Stefan,

On Fri, 2023-04-28 at 11:59 +0200, Stefan Roese wrote:
> Hi Nuno Sá,
> 
> On 4/26/23 16:16, Nuno Sá wrote:
> > flash_get_size() will get the flash size from the device itself and go
> > through all erase regions to read protection status. However, the device
> > mappable region (eg: devicetree reg property) might be lower than the
> > device full size which means that the above cycle will result in a data
> > bus exception. This change fixes it by reading the 'addr_size' during
> > probe() and also use that as one possible upper limit.
> > 
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > 
> > v2:
> >   * Fix compilation when CONFIG_CFI_FLASH is not set. Done by redefining
> > cfi_flash_bank_size() when CONFIG_CFI_FLASH is set (by returning dts
> > size).
> > 
> > v3:
> >   * Fix another compilation warning by explicitly casting to unsigned
> > long in cfi_flash_bank_size()
> > 
> > Stefan, I did ran a world build [1] by opening a PR in github (to force CI
> > to run). However I had to bypass the pytest stage (it was giving me some
> > unrelated problems) and there are a couple of jobs failing but the
> > errors apparently are not related to this patchset. Hopefully things now
> > pass in your tests.
> > 
> > [1]: https://github.com/u-boot/u-boot/pull/281
> 
> Unfortunately this breaks my usual Azure CI build in the test_py phase.
> And this works without any issues without those 2 patches applied. So
> its related to these changes.
> 

Sorry for this... It seemed unrelated and the logs don't say much about why is
it failing. I'll try to see what's the problem.

- Nuno Sá