From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D50FC77B60 for ; Fri, 28 Apr 2023 11:46:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7C79E863B0; Fri, 28 Apr 2023 13:46:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="paD7XitT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 14ED88638A; Fri, 28 Apr 2023 13:23:08 +0200 (CEST) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C6BBD85EE8 for ; Fri, 28 Apr 2023 13:23:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=noname.nuno@gmail.com Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-50a14564d17so16149144a12.0 for ; Fri, 28 Apr 2023 04:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682680985; x=1685272985; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=GY9EBtw3ImsHceb7Ywq71BPGAE8NtZL2qNtYUh4cz9g=; b=paD7XitT0Ww48va1RqFDU7FdU/m1gvuAKDSPcrJ+kVo0RVZYGlGtj/sotraYq8mk6h OiwIr1UZt71zfzODkuq2yrN8tmL7wgXYDoYOErpiUNPjZZ0NNvtAZt4Esoz5f7bJAgXR evP01bwSoeJdhDujPXbQb9EcQC4Tct21OGp7eZ7pLuOfHr5ZPah8rAyytBwctoyhZnFj ayQcIpfbEuzVWW2x29yGH6MzQymFZJdyCavv7bLRZSzDhzLNNGUNjjUMoFx3haa+yiNg QYT2EGL0FhamecgDns5VND7rdWfm1WQFyBQJ1h8sxQzvvdu0IvrioLQL+btQm11VV2zj KNwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682680985; x=1685272985; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GY9EBtw3ImsHceb7Ywq71BPGAE8NtZL2qNtYUh4cz9g=; b=DglgO/TWmbfz0vwfoh7f38hq4tyYPaYqm68Ia1a1GpmjPRRVUMdJ++jpRSdiNvOnOR ajdtbhML/vozdRB9xcYqZ9NVKZ9DW5C26NVYBxGGwjVVBadBUmWy3aoLFYmRlRQyEB4M /E7RT6tdsOX5UWNnDXa1vu5V0CKYgmdg2HeSbBq5Z7ZcGXYMCD44AhkoQD4tUIAROhdI NqZyOJlspR4IglqeySwj4bjFuT+qhx0oJyOumKPFzMl7MNEAbYE32nM8Inuv2682qH6p kpReBypoVV1h6lkIkgL9EXSmcoYtaMjtefcqnn830KntxduBmVD4V7Xv1JCvNyBoRhe6 ED8w== X-Gm-Message-State: AC+VfDx0ek3/J2iv9SIdMUR3rvmG8OKD3YVRhimgt7yY4V3iEwDCk9RX lwU8fYTBSM04wjEdk+8PIL4= X-Google-Smtp-Source: ACHHUZ79ewbr88vD/25mUt/Ds8wWBMLZnRwUdRbxuk3Ri/Lv93cQ9AqzZObK06dQG2a3BnRX3Iv98Q== X-Received: by 2002:a17:906:6c6:b0:94b:769f:3ba3 with SMTP id v6-20020a17090606c600b0094b769f3ba3mr9341725ejb.8.1682680984970; Fri, 28 Apr 2023 04:23:04 -0700 (PDT) Received: from ?IPv6:2003:f6:ef05:8700:c599:e44a:8287:c91c? (p200300f6ef058700c599e44a8287c91c.dip0.t-ipconnect.de. [2003:f6:ef05:8700:c599:e44a:8287:c91c]) by smtp.gmail.com with ESMTPSA id bj1-20020a170906b04100b0094f7acbafe0sm10072529ejb.177.2023.04.28.04.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 04:23:04 -0700 (PDT) Message-ID: <0d4550ef73b225fe8c60c1949bbc630b2d4966f2.camel@gmail.com> Subject: Re: [PATCH v3 1/2] mtd: cfi: respect reg address length From: Nuno =?ISO-8859-1?Q?S=E1?= To: Stefan Roese , Nuno =?ISO-8859-1?Q?S=E1?= , u-boot@lists.denx.de Date: Fri, 28 Apr 2023 13:25:16 +0200 In-Reply-To: References: <20230426141656.1596908-1-nuno.sa@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Mailman-Approved-At: Fri, 28 Apr 2023 13:46:05 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Stefan, On Fri, 2023-04-28 at 11:59 +0200, Stefan Roese wrote: > Hi Nuno S=C3=A1, >=20 > On 4/26/23 16:16, Nuno S=C3=A1 wrote: > > flash_get_size() will get the flash size from the device itself and go > > through all erase regions to read protection status. However, the devic= e > > mappable region (eg: devicetree reg property) might be lower than the > > device full size which means that the above cycle will result in a data > > bus exception. This change fixes it by reading the 'addr_size' during > > probe() and also use that as one possible upper limit. > >=20 > > Signed-off-by: Nuno S=C3=A1 > > --- > >=20 > > v2: > > =C2=A0 * Fix compilation when CONFIG_CFI_FLASH is not set. Done by rede= fining > > cfi_flash_bank_size() when CONFIG_CFI_FLASH is set (by returning dts > > size). > >=20 > > v3: > > =C2=A0 * Fix another compilation warning by explicitly casting to unsig= ned > > long in cfi_flash_bank_size() > >=20 > > Stefan, I did ran a world build [1] by opening a PR in github (to force= CI > > to run). However I had to bypass the pytest stage (it was giving me som= e > > unrelated problems) and there are a couple of jobs failing but the > > errors apparently are not related to this patchset. Hopefully things no= w > > pass in your tests. > >=20 > > [1]: https://github.com/u-boot/u-boot/pull/281 >=20 > Unfortunately this breaks my usual Azure CI build in the test_py phase. > And this works without any issues without those 2 patches applied. So > its related to these changes. >=20 Sorry for this... It seemed unrelated and the logs don't say much about why= is it failing. I'll try to see what's the problem. - Nuno S=C3=A1