From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Bin Meng <bmeng.cn@gmail.com>, Marek Vasut <marex@denx.de>
Cc: Ryder Lee <ryder.lee@mediatek.com>,
Weijie Gao <weijie.gao@mediatek.com>,
GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
<u-boot@lists.denx.de>, Tom Rini <trini@konsulko.com>,
Xin Lin <Xin.Lin@mediatek.com>
Subject: Re: [RESEND PATCH] usb: mtu3: flush cache for the first GPD when allocate GPD ring
Date: Wed, 3 Nov 2021 10:39:51 +0800 [thread overview]
Message-ID: <0d6989eb6a4a75434e3bc77df7906b3e09413fd9.camel@mediatek.com> (raw)
In-Reply-To: <20211021053307.8502-1-chunfeng.yun@mediatek.com>
Hi Marek,
On Thu, 2021-10-21 at 13:33 +0800, Chunfeng Yun wrote:
> When allocate the GPD ring, and tell its address to the controller,
> then
> the driver starts or resumes the QMU, the controller will try to
> access
> the first GPD, so need flush the first one to avoid wrong GPD status.
>
> Reported-by: Xin Lin <Xin.Lin@mediatek.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/usb/mtu3/mtu3_qmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/mtu3/mtu3_qmu.c
> b/drivers/usb/mtu3/mtu3_qmu.c
> index 95eaf6d236..e8dc0095ab 100644
> --- a/drivers/usb/mtu3/mtu3_qmu.c
> +++ b/drivers/usb/mtu3/mtu3_qmu.c
> @@ -112,6 +112,7 @@ int mtu3_gpd_ring_alloc(struct mtu3_ep *mep)
> memset(gpd, 0, QMU_GPD_RING_SIZE);
> ring->dma = (dma_addr_t)gpd;
> gpd_ring_init(ring, gpd);
> + mtu3_flush_cache((uintptr_t)gpd, sizeof(*gpd));
>
> return 0;
> }
Could you please pick up this patch?
Thanks
next prev parent reply other threads:[~2021-11-03 2:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 5:33 [RESEND PATCH] usb: mtu3: flush cache for the first GPD when allocate GPD ring Chunfeng Yun
2021-11-02 2:45 ` Chunfeng Yun
2021-11-02 2:50 ` Chunfeng Yun
2021-11-02 7:19 ` Chunfeng Yun
2021-11-03 2:31 ` Chunfeng Yun
2021-11-03 2:39 ` Chunfeng Yun [this message]
2021-11-03 10:13 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d6989eb6a4a75434e3bc77df7906b3e09413fd9.camel@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=GSS_MTK_Uboot_upstream@mediatek.com \
--cc=Xin.Lin@mediatek.com \
--cc=bmeng.cn@gmail.com \
--cc=marex@denx.de \
--cc=ryder.lee@mediatek.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox