[U-Boot-Users] [PATCH] ATSTK1002: Remove default ethernet addresses

Haavard Skinnemoen
2007-10-29T15:55:55Z

On Mon, 29 Oct 2007 16:29:35 +0100
"Ulf Samuelsson" <ulf@atmel.com> wrote:

> I am not opposed to the change, I just point out that there is a use for
> an initial ethernet address and an initial ip address.

Ok. I think I understand. You don't want the CONFIG_ETHADDR definitions
to go away altogether. Right?

> It all boils downto, that some people prefer a certain way and others prefer
> to do it in a different way. I believe in letting the customer decide his method.

Sure. So the customer can add those definitions back, along with a
default bootcmd and possibly an IP address. What is the problem?

Actually, there is a problem: If the environment containing the real
ethernet address(es) is erased, the "temporary" addresses will be
restored. I'm not going to actively prevent anyone from shooting
themselves in the foot though; as long as it isn't the default, I
consider the problem solved.

> It is important, to solve the problem with duplicate ethernet addresses.

Yes, and that's what I'm trying to do. Setting CONFIG_ETHADDR and
CONFIG_ETH1ADDR in the u-boot source shipped from us was a mistake, and
I don't think you really disagree with that. I'm not proposing that the
macros should go away altogether.

H?vard