[U-Boot] [PATCH v5] cmd: usb: add blk, emulation devices to ignore list as needed

[Marek Vasut <marex@denx.de>]

On 10/18/2017 03:30 AM, Suneel Garapati wrote:
> On Tue, Oct 17, 2017 at 6:22 PM, Marek Vasut <marex@denx.de> wrote:
>> On 10/18/2017 01:50 AM, Suneel Garapati wrote:
>>> On Tue, Oct 17, 2017 at 5:43 AM, Marek Vasut <marex@denx.de> wrote:
>>>> On 10/17/2017 05:21 AM, Bin Meng wrote:
>>>>> +Marek, Tom,
>>>>
>>>> Well, if the author CCed me in the first place, that'd be useful.
>>>>
>>>>> On Tue, Oct 17, 2017 at 11:14 AM, Suneel Garapati
>>>>> <suneelglinux@gmail.com> wrote:
>>>>>> Hi Bin/Simon,
>>>>>>
>>>>>> Request to know if this will be applied for v2017.11
>>>>>>
>>>>>
>>>>> Not sure which of you should pick this up for v2017.11.
>>>>
>>>> The commit message makes no sense, can you explain to me what this patch
>>>> tries to achieve ?
>>> usb tree/info commands for DM_USB should ignore blk child under mass
>>> storage and usb_emul devices
>>> otherwise u-boot crashes.
>>
>> And it crashes because ... why ? I am sure you analyzed the problem and
>> that analysis/explanation should be in the commit message too.
> 
> It crashes because the next call of tree graph on blk device will try
> to fetch config interface class descriptors
> assuming it as usb_device structure.

Assume I know nothing about the subsystem, expand on this a bit and then
it's gonna be good. This is the kind of description that should be in
the commit message, to make it obvious what the problem is and how it
got fixed, without having to think too much about what the author meant.

> I will add the above to commit message and send v6.
> 
> Regards,
> Suneel
>>
>> --
>> Best regards,
>> Marek Vasut


-- 
Best regards,
Marek Vasut