From: Michal Simek <michal.simek@amd.com>
To: Jassi Brar <jaswinder.singh@linaro.org>
Cc: jassisinghbrar@gmail.com, u-boot@lists.denx.de,
ilias.apalodimas@linaro.org, etienne.carriere@linaro.org,
trini@konsulko.com, sjg@chromium.org, sughosh.ganu@linaro.org,
xypron.glpk@gmx.de, takahiro.akashi@linaro.org,
Masami Hiramatsu <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image
Date: Fri, 14 Apr 2023 15:53:10 +0200 [thread overview]
Message-ID: <0f5768f7-60bb-9da0-e295-3aab936292d5@amd.com> (raw)
In-Reply-To: <CAJe_ZhevKuvbB+xFapLZBvpTgxQ_jxETTaurL=tDNaXtmpxirA@mail.gmail.com>
On 4/10/23 06:05, Jassi Brar wrote:
> On Wed, 29 Mar 2023 at 07:29, Michal Simek <michal.simek@amd.com> wrote:
>> On 3/27/23 23:16, jassisinghbrar@gmail.com wrote:
>
>>> diff --git a/tools/mkfwumdata.c b/tools/mkfwumdata.c
>>> new file mode 100644
>>> index 0000000000..43dabf3b72
>>> --- /dev/null
>>> +++ b/tools/mkfwumdata.c
>>> @@ -0,0 +1,334 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * Copyright (c) 2023, Linaro Limited
>>> + */
>>> +
>>> +#include <errno.h>
>>> +#include <getopt.h>
>>> +#include <limits.h>
>>> +#include <stdio.h>
>>> +#include <stdint.h>
>>> +#include <stdlib.h>
>>> +#include <string.h>
>>> +#include <u-boot/crc.h>
>>> +#include <unistd.h>
>>> +#include <uuid/uuid.h>
>>> +
>>> +/* This will dynamically allocate the fwu_mdata */
>>> +#define CONFIG_FWU_NUM_BANKS 0
>>> +#define CONFIG_FWU_NUM_IMAGES_PER_BANK 0
>>
>> These two are completely unused.
>>
> these are necessary for include/fwu_mdata.h that comes later.
If that's come later, add it later.
M
next prev parent reply other threads:[~2023-04-14 13:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 21:14 [PATCH v4 0/6] FWU: Add support for mtd backed feature on DeveloperBox jassisinghbrar
2023-03-27 21:15 ` [PATCH v4 1/6] FWU: Add FWU metadata access driver for MTD storage regions jassisinghbrar
2023-03-29 11:59 ` Michal Simek
2023-04-10 3:56 ` Jassi Brar
2023-04-14 13:56 ` Michal Simek
2023-04-14 15:09 ` Jassi Brar
2023-05-19 12:21 ` Ilias Apalodimas
2023-05-19 12:45 ` Michal Simek
2023-05-19 20:54 ` Tom Rini
2023-03-27 21:16 ` [PATCH v4 2/6] FWU: mtd: Add helper functions for accessing FWU metadata jassisinghbrar
2023-03-29 11:55 ` Michal Simek
2023-04-10 4:02 ` Jassi Brar
2023-03-27 21:16 ` [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image jassisinghbrar
2023-03-29 12:28 ` Michal Simek
2023-04-10 4:05 ` Jassi Brar
2023-04-14 13:53 ` Michal Simek [this message]
2023-04-14 15:02 ` Jassi Brar
2023-04-17 6:37 ` Michal Simek
2023-04-17 13:48 ` Jassi Brar
2023-04-17 14:29 ` Michal Simek
2023-04-17 14:50 ` Jassi Brar
2023-03-29 20:02 ` Simon Glass
2023-04-10 4:25 ` Jassi Brar
2023-04-14 13:52 ` Michal Simek
2023-04-19 1:46 ` Simon Glass
2023-04-19 2:57 ` Jassi Brar
2023-04-19 22:40 ` Simon Glass
2023-03-30 6:07 ` Heinrich Schuchardt
2023-04-10 4:11 ` Jassi Brar
2023-03-27 21:16 ` [PATCH v4 4/6] dt: fwu: developerbox: enable fwu banks and mdata regions jassisinghbrar
2023-03-29 11:52 ` Michal Simek
2023-03-27 21:16 ` [PATCH v4 5/6] configs: move to new flash layout and boot flow jassisinghbrar
2023-03-27 21:16 ` [PATCH v4 6/6] fwu: DeveloperBox: add support for FWU jassisinghbrar
2023-03-29 13:01 ` Michal Simek
2023-04-10 4:21 ` Jassi Brar
2023-04-14 13:52 ` Michal Simek
2023-03-29 13:14 ` [PATCH v4 0/6] FWU: Add support for mtd backed feature on DeveloperBox Michal Simek
2023-03-30 13:35 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f5768f7-60bb-9da0-e295-3aab936292d5@amd.com \
--to=michal.simek@amd.com \
--cc=etienne.carriere@linaro.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=masami.hiramatsu@linaro.org \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=takahiro.akashi@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox