U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Emanuele Ghidoli <ghidoliemanuele@gmail.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	u-boot@lists.denx.de
Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com,
	Fabio Estevam <festevam@gmail.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
	Stefano Babic <sbabic@nabladev.com>,
	Tom Rini <trini@konsulko.com>,
	u-boot@lists.u-boot-project.org
Subject: Re: [PATCH] ddr: imx: keep ddrmix_initialized out of .bss
Date: Thu, 29 Oct 2026 17:47:10 +0100	[thread overview]
Message-ID: <0f57df3e-52ed-46c2-a98d-3aa6f5beabb5@gmail.com> (raw)
In-Reply-To: <20261029160513.666555-1-dario.binacchi@amarulasolutions.com>



On 10/29/26 17:05, Dario Binacchi wrote:
> ddr_init() is called from board_init_f(), before .bss is cleared, so
> ddrmix_initialized may already be non-zero on the first call. The DDRMIX
> cold reset is then run on a DDRMIX that has never been initialized and
> the SPL hangs (with DEBUG enabled in ddr_init.c):
> 
>   DDRINFO: start DRAM init
>   DDRINFO: cold reset the DDRMIX
> 
> Move ddrmix_initialized to .data, so that it is zero on the first call.
> 
> Fixes: ae03528affd3 ("ddr: imx: Recreate the power-on state before repeating ddr_init()")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 

[...]

3 out of 6 Verdin iMX8M Plus and the SMARC iMX8M Plus SoMs in our CI farm were
hanging in SPL, this patch fixes it.

Thanks!

Emanuele

Reviewed-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Tested-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>

      parent reply	other threads:[~2026-10-29 16:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 16:05 [PATCH] ddr: imx: keep ddrmix_initialized out of .bss Dario Binacchi
2026-10-29 16:17 ` Frieder Schrempf
2026-10-29 16:47 ` Emanuele Ghidoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f57df3e-52ed-46c2-a98d-3aa6f5beabb5@gmail.com \
    --to=ghidoliemanuele@gmail.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=michael@amarulasolutions.com \
    --cc=sbabic@nabladev.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox