From mboxrd@z Thu Jan 1 00:00:00 1970 From: geniis Date: Thu, 21 Oct 2010 00:08:06 +0800 (CST) Subject: [U-Boot] maybe a priority mistake in mpc85xx_cpu\init.c Message-ID: <1000d70.d8d1.12bca65bb27.Coremail.geniis@126.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de hi, I notice that in "arch\powerpc\cpu\mpc85xx\cpu_init.c" line 193, version 2010.06: if (! memctl->br1 & 1) The original intention is to check if V bit of BR1 is set or not, but the operator "!" has higher priority than "&" ,I think it should be changed to: if (! (memctl->br1 & 1)) please check this question, thanks!