From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= <benoit.thebaudeau@advansee.com>
Date: Tue, 8 Jan 2013 11:24:24 +0100 (CET)
Subject: [U-Boot] [PATCH 1/2] mxc nand: Add support for i.MX5
In-Reply-To: <1357637609-18663-1-git-send-email-marex@denx.de>
References: <1357637609-18663-1-git-send-email-marex@denx.de>
Message-ID: <1006715218.53219.1357640664105.JavaMail.root@advansee.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Marek Vasut,

On Tuesday, January 8, 2013 10:33:29 AM, Marek Vasut wrote:
> Subject: [PATCH 1/2] mxc nand: Add support for i.MX5

Where is the 2/2?

> 
> From: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> 
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
>  arch/arm/include/asm/arch-mx5/imx-regs.h |    9 ++
>  drivers/mtd/nand/mxc_nand.c              |  219
>  ++++++++++++++++++++++--------
>  include/fsl_nfc.h                        |  149 +++++++++++++-------
>  nand_spl/nand_boot_fsl_nfc.c             |  114 ++++++++++++----
>  4 files changed, 364 insertions(+), 127 deletions(-)
> 
> NOTE: I'm seeing issues when this is compiled into U-Boot. U-Boot
> won't boot on
> my MX53 board and will hang right after printing "DRAM:" and before
> printing the
> CPU info. I suspect it's some kind of unaligned access.

OK. I'm waiting for your test results. It works for me on i.MX51 with 2012.07.

> 
> NOTE2: I fixed a few complaints from GCC

Which ones? I don't see any such change in this new version.

> and rebased on top of
> master.

OK.

[--snip--]
> @@ -698,7 +757,7 @@ static int mxc_nand_correct_data(struct mtd_info
> *mtd, u_char *dat,
>  	 * additional correction.  2-Bit errors cannot be corrected by
>  	 * HW ECC, so we need to return failure
>  	 */
> -	uint16_t ecc_status = readw(&host->regs->ecc_status_result);
> +	uint32_t ecc_status = readnfc(&host->regs->ecc_status_result);
        ^
Here it was uint16_t in my last version, and this was correct since this is code
for MXC_NFC_V1. This change should not hurt, but it was not necessary.

Is this change related to the GCC complaints that you mentioned?

>  
>  	if (((ecc_status & 0x3) == 2) || ((ecc_status >> 2) == 2)) {
>  		MTDDEBUG(MTD_DEBUG_LEVEL0,
[--snip--]

The other changes (i.e. the rebase) are fine with me.

Best regards,
Beno?t