From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/5] Add env var giving the board revision
Date: Sun, 12 Aug 2012 23:35:26 +0200 (CEST) [thread overview]
Message-ID: <1012612599.2335651.1344807326593.JavaMail.root@advansee.com> (raw)
In-Reply-To: <20120812212013.2A505202C07@gemini.denx.de>
Dear Wolfgang Denk,
> > OK. Actually, the only reason for which I need this patch is to
> > make a variable
> > read-only, and the only reason for which you reject it is because
> > you fear that
> > it breaks something.
> >
> > So we could add a config like CONFIG_BOARD_REV_RO_VARIABLE to
> > enable the code in
> > my patch. But I think you won't like that either because you will
> > find it too
> > specific.
>
> No, this may solve your problem, but will never scale for any real
> life use.
OK.
> > What about adding a config like CONFIG_READONLY_VARS that would be
> > an array
> > initializer containing the names of the board-specific variables to
> > make
> > read-only? _do_env_set() and fw_env_write() would use it besides
> > the hard-coded
> > serial# and the like. That would give something like:
> > #define CONFIG_READONLY_VARS {"my_ro_var1", "my_ro_var2",
> > "board_rev"}
> > That would be a very simple solution to make everyone happy before
> > Wolfgang
> > implements a more sophisticated solution with read-only and
> > volatile flags. What
> > do you think?
>
> Please feel free to add this to your local code.
By "local", do you mean that this new suggestion would still not be generic
enough for you to be interested in it for a patch?
Best regards,
Beno?t
next prev parent reply other threads:[~2012-08-12 21:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 17:44 [U-Boot] [PATCH 0/5] Cleanup and extend env vars Benoît Thébaudeau
2012-08-10 17:45 ` [U-Boot] [PATCH 1/5] fw_env: Add env vars describing U-Boot target board Benoît Thébaudeau
2012-09-18 19:04 ` [U-Boot] [U-Boot, " Tom Rini
2012-08-10 17:45 ` [U-Boot] [PATCH 2/5] env_common: Add missing ethprime Benoît Thébaudeau
2012-09-18 19:05 ` [U-Boot] [U-Boot,2/5] " Tom Rini
2012-08-10 17:45 ` [U-Boot] [PATCH 3/5] env import/export: Remove from help if disabled Benoît Thébaudeau
2012-08-11 17:48 ` Mike Frysinger
2012-09-18 19:05 ` [U-Boot] [U-Boot, " Tom Rini
2012-08-10 17:45 ` [U-Boot] [PATCH 4/5] README: The ver env var is not read-only Benoît Thébaudeau
2012-08-11 17:48 ` Mike Frysinger
2012-08-11 18:07 ` Benoît Thébaudeau
2012-08-12 11:54 ` Wolfgang Denk
2012-08-12 13:58 ` Benoît Thébaudeau
2012-08-12 14:49 ` Mike Frysinger
2012-08-13 13:01 ` [U-Boot] [PATCH] README: Update ver env var description Benoît Thébaudeau
2012-08-17 4:20 ` Mike Frysinger
2012-09-02 16:56 ` Wolfgang Denk
2012-08-12 11:49 ` [U-Boot] [PATCH 4/5] README: The ver env var is not read-only Wolfgang Denk
2012-08-10 17:46 ` [U-Boot] [PATCH 5/5] Add env var giving the board revision Benoît Thébaudeau
2012-08-11 17:48 ` Mike Frysinger
2012-08-11 19:11 ` Benoît Thébaudeau
2012-08-12 11:58 ` Wolfgang Denk
2012-08-12 14:02 ` Benoît Thébaudeau
2012-08-12 14:09 ` Benoît Thébaudeau
2012-08-12 21:06 ` Wolfgang Denk
2012-08-12 21:21 ` Jeroen Hofstee
2012-08-12 14:54 ` Mike Frysinger
2012-08-12 17:11 ` Benoît Thébaudeau
2012-08-12 21:20 ` Wolfgang Denk
2012-08-12 21:35 ` Benoît Thébaudeau [this message]
2012-08-13 9:59 ` Wolfgang Denk
2012-08-13 0:28 ` Mike Frysinger
2012-08-12 21:05 ` Wolfgang Denk
2012-08-12 11:51 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1012612599.2335651.1344807326593.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox