[PATCH v2 8/8] test: dm: add a test for class button

[Philippe REYNES <philippe.reynes@softathome.com>]

Hi Simon,

> Hi Philippe,
> 
> On Mon, 20 Jul 2020 at 08:30, Philippe REYNES
> <philippe.reynes@softathome.com> wrote:
>> 
>> Hi Simon,
>> 
>> > Hi Philippe,
>> > 
>> > On Fri, 17 Jul 2020 at 06:22, Philippe Reynes
>> > <philippe.reynes@softathome.com> wrote:
>> >> 
>> >> Add a test to confirm that we can read button state
>> >> using the button-gpio driver.
>> >> 
>> >> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
>> >> ---
>> >> Changelog:
>> >> v2:
>> >> - new commit in the serie
>> >> 
>> >> test/dm/Makefile | 1 +
>> >> test/dm/button.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> >> 2 files changed, 75 insertions(+)
>> >> create mode 100644 test/dm/button.c
>> > 
>> > This seems to fail with 'make qcheck'. Can you please take a look?
>> > I've left it unapplied for now.
>> 
>> I've tried to reproduce this issue, but make qcheck don't work for me.
>> I have some issues with test for binman, patman, and dtoc.
>> 
>> Could you provide me the log of the issue with 'make qcheck' please ?
> 
> See below. What sort of issues are you seeing? I wonder if we should
> have a script to set up for running these tests fully.
> 
> 
> ======================================================= FAILURES
> =======================================================
> ______________________________________________
> test_button_exit_statuses
> _______________________________________________
> 
> u_boot_console = <u_boot_console_sandbox.ConsoleSandbox object at
> 0x7fe1121eef60>
> 
> @pytest.mark.boardspec('sandbox')
> @pytest.mark.buildconfigspec('cmd_button')
> def test_button_exit_statuses(u_boot_console):
> """Test that non-input button commands correctly return the command
> success/failure status."""
> 
> expected_response = 'rc:0'
> response = u_boot_console.run_command('button list; echo rc:$?')
> assert(expected_response in response)
> response = u_boot_console.run_command('button summer; echo rc:$?')
>> assert(expected_response in response)
> E assert 'rc:0' in "Button 'summer' not found (err=-16)\r\r\nrc:1"
> 
> test/py/tests/test_button.py:15: AssertionError
> ------------------------------------------------- Captured stdout call
> -------------------------------------------------
> => button list; echo rc:$?
> summer <inactive>
> christmas <inactive>
> rc:0
> => => button summer; echo rc:$?
> Button 'summer' not found (err=-16)
> rc:1
> =>
> ============================== 1 failed, 512 passed, 59 skipped, 105
> deselected in 43.38s ==============================


I think I have found the issue. This issue only appears after the commit
9ba84329dc45 ("sandbox, test: add test for GPIO_HOG function") that uses
gpio_a 0, 1, 2 and 3.

I've sent a patch do change the gpio used for hog on sandbox. With this
patch, I don't reproduce this issue.

> Regards,
> Simon

Regards,
Philippe