public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alessio Centazzo <acpatin@yahoo.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] PATCH: Fixed PPC4xx compilation warning in 4xx_enet.c
Date: Wed, 17 Jun 2009 09:37:26 -0700 (PDT)	[thread overview]
Message-ID: <10276.17780.qm@web51904.mail.re2.yahoo.com> (raw)


This patch fixes a compilation warning for some Ethernet PHY-less PPC4xx platforms (440SPE based ones) and a potential compilation error for 440SP platforms (use of undefined 'ethgroup' variable).  In the original code and in case of 440SPE platforms, 'ethgroup' is initialized to -1 and never modified.  Later in the function, within an #ifdef statement, an 'if statement' executes code only if 'ethgroup' is set to 4, therefore it is harmless to avoid executing the 'if statement' by removing the CONFIG_440SPE from the affected #ifdefs.  In case of 440SP platforms  with on-board Ethernet PHY, 'ethgroup' is undefined but used (there are not such platforms in the repository yet). All other architectures are not affected by this
change.
This is the current warning message with a Ethernet PHY-less 440SPE platform build (there is not such platform in the repository yet):

4xx_enet.c: In function 'ppc_4xx_eth_init':
4xx_enet.c:880: warning: unused variable 'ethgroup'

Signed-off-by: Alessio Centazzo acpatin {AT} yahoo {DOT} com

diff -Nau u-boot-2009.06/drivers/net/4xx_enet.c.orig u-boot-2009.06/drivers/net/4xx_enet.c
--- u-boot-2009.06/drivers/net/4xx_enet.c.orig    2009-06-14 12:30:39.000000000 -0700
+++ u-boot-2009.06/drivers/net/4xx_enet.c    2009-06-17 08:34:54.000000000 -0700
@@ -873,7 +873,7 @@
     defined(CONFIG_405EX)
     u32 opbfreq;
     sys_info_t sysinfo;
-#if defined(CONFIG_440GX) || defined(CONFIG_440SPE) || \
+#if defined(CONFIG_440GX) || \
     defined(CONFIG_440EPX) || defined(CONFIG_440GRX) || \
     defined(CONFIG_460EX) || defined(CONFIG_460GT) || \
     defined(CONFIG_405EX)
@@ -1122,7 +1122,6 @@
 
 #if defined(CONFIG_440GX) || \
     defined(CONFIG_440EPX) || defined(CONFIG_440GRX) || \
-    defined(CONFIG_440SP) || defined(CONFIG_440SPE) || \
     defined(CONFIG_460EX) || defined(CONFIG_460GT) || \
     defined(CONFIG_405EX)


      

             reply	other threads:[~2009-06-17 16:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17 16:37 Alessio Centazzo [this message]
2009-06-23  8:32 ` [U-Boot] PATCH: Fixed PPC4xx compilation warning in 4xx_enet.c Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10276.17780.qm@web51904.mail.re2.yahoo.com \
    --to=acpatin@yahoo.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox