From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] gpio: mxc_gpio: Fix gpio_get_value() when the GPIO is an output
Date: Sun, 29 Sep 2013 21:45:30 +0200 (CEST) [thread overview]
Message-ID: <1056648236.2248666.1380483930698.JavaMail.zimbra@advansee.com> (raw)
In-Reply-To: <CAP9ODKob5LF8T9P8xeoGQDj_-D2MMuiFoiU5Z+zqSjyVxiP1=w@mail.gmail.com>
Hi Otavio,
On Sunday, September 29, 2013 9:42:44 PM, Otavio Salvador wrote:
> On Sun, Sep 29, 2013 at 4:25 PM, Beno?t Th?baudeau
> <benoit.thebaudeau@advansee.com> wrote:
> ...
> > Hence, gpio_get_value() should be left unchanged (using PSR in all cases),
> > and
> > SION should be set for all GPIOs in the i.MX6 pin definition header files.
>
> I just does not follow why this preferred against Fabio's proposed
> patch to read from DR?
Because in case of a level conflict between the GPIO output and some other
hardware on the board, one would expect gpio_get_value() to return the actual
pin level, and not the level that the GPIO output tries (but possibly fails) to
apply on this pin.
Best regards,
Beno?t
next prev parent reply other threads:[~2013-09-29 19:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 17:22 [U-Boot] [PATCH] gpio: mxc_gpio: Fix gpio_get_value() when the GPIO is an output Fabio Estevam
2013-09-28 19:04 ` Otavio Salvador
2013-09-29 13:21 ` Benoît Thébaudeau
2013-09-29 17:09 ` Eric Bénard
2013-09-29 17:48 ` Otavio Salvador
2013-09-29 18:19 ` Eric Bénard
2013-09-29 18:22 ` Fabio Estevam
2013-09-29 18:26 ` Eric Bénard
2013-09-29 18:48 ` Fabio Estevam
2013-09-29 18:50 ` Benoît Thébaudeau
2013-09-29 18:58 ` Fabio Estevam
2013-09-29 19:25 ` Benoît Thébaudeau
2013-09-29 19:42 ` Otavio Salvador
2013-09-29 19:45 ` Benoît Thébaudeau [this message]
2013-09-29 19:49 ` Otavio Salvador
2013-09-29 22:24 ` Otavio Salvador
2013-09-30 1:32 ` Fabio Estevam
2013-09-30 11:08 ` Benoît Thébaudeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1056648236.2248666.1380483930698.JavaMail.zimbra@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox