From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Date: Sat, 28 Sep 2013 16:17:02 +0200 (CEST) Subject: [U-Boot] [PATCH 6/7] status_led: Add support for inverted LEDs In-Reply-To: <1380338659-7896-6-git-send-email-otavio@ossystems.com.br> References: <1380338659-7896-1-git-send-email-otavio@ossystems.com.br> <1380338659-7896-6-git-send-email-otavio@ossystems.com.br> Message-ID: <1059532413.2231026.1380377822470.JavaMail.zimbra@advansee.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, On Saturday, September 28, 2013 5:24:17 AM, Otavio Salvador wrote: > There're cases we want to use active-low LEDs and the 'inverted' logic > needs to be added. This includes it using the STATUS_LED_INVERT macro. There is already a STATUS_LED_ACTIVE definition (though not one per LED) in include/status_led.h for some platforms. Wouldn't it be worth keeping the same naming here for consistency (i.e. STATUS_LED_ACTIVEn, which would also imply exchanging 0/1 values)? [...] Best regards, Beno?t