From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thirupathaiah Annapureddy Date: Wed, 8 Jan 2020 22:28:14 -0800 Subject: [PATCH] Revert "dm: core: Scan "/firmware" node by default" In-Reply-To: References: <20200108032402.26721-1-thiruan@linux.microsoft.com> Message-ID: <10769aea-e2e5-0d88-8ba4-2a1ccb8d7a81@linux.microsoft.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 1/8/2020 9:39 AM, Simon Glass wrote: > Hi T, > > On Tue, 7 Jan 2020 at 20:24, Thirupathaiah Annapureddy > wrote: >> >> Subnodes under "/firmware" node are scanned twice in dm_scan_fdt_node >> and dm_extended_scan_fdt. This patch removes the double scanning. >> >> This reverts commit 1712ca21924bff678f19fd3141f435408d23bdbf. >> >> Signed-off-by: Thirupathaiah Annapureddy >> --- >> drivers/core/root.c | 8 +------- >> 1 file changed, 1 insertion(+), 7 deletions(-) >> >> diff --git a/drivers/core/root.c b/drivers/core/root.c >> index e85643819e..daf7c61190 100644 >> --- a/drivers/core/root.c >> +++ b/drivers/core/root.c >> @@ -342,14 +342,8 @@ int dm_extended_scan_fdt(const void *blob, bool pre_reloc_only) >> } >> >> ret = dm_scan_fdt_ofnode_path("/clocks", pre_reloc_only); >> - if (ret) { >> - debug("scan for /clocks failed: %d\n", ret); >> - return ret; >> - } >> - >> - ret = dm_scan_fdt_ofnode_path("/firmware", pre_reloc_only); >> if (ret) >> - debug("scan for /firmware failed: %d\n", ret); >> + debug("scan for /clocks failed: %d\n", ret); >> >> return ret; >> } >> -- >> 2.24.1 >> > > I actually think it would be better to remove this from > dm_scan_fdt_node() since that function looks for f > Hi Simon, Thanks. I will address your comment and send new patch. My rationale for removing the scanning from dm_extended_scan_fdt() was based on the order of the scan. Why do you think removing the scan from dm_extended_scan_fdt() is better? --Thiru