public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] CFI driver
Date: Wed, 27 Oct 2004 14:55:00 -0500	[thread overview]
Message-ID: <1098906900.7217.41.camel@localhost.localdomain> (raw)
In-Reply-To: <16765.12175.401464.214322@astp0002.localdomain>

Yuli,

I have confirm the problem on more boards.

On Mon, 2004-10-25 at 11:53, Yuli Barcohen wrote:
>     York> Yes. I agree. I polled the DQ7 at the same address of being
>     York> written. I know the AMD polling algorithm. Actually I have
>     York> been using polling DQ7 for a long time. Hundreds of our boards
>     York> were shipped with this algorithm. I am very sure the image has
>     York> been programmed correctly.
> 
> So I assume that if you program kernel image you can then successfully
> boot it. Correct?
Yes.

>     York> I also found the flash_make_cmd has some defect. You cannot
>     York> simply multiply the offset with the port width. That would
>     York> generate error address if you are using 8-bit port
>     York> width. Modification is needed for 32-bit chip width. I made
>     York> modification. But I need some boards to verify.
> 
> There can be bugs for the very same reason: I haven't got enough boards
> to verify all possible configuration. In particular, I've got no board
> using 8-bit port width. I received recently a board with 32-bit flash
> (2x16) and the CFI driver worked unchanged. Maybe only 4x8 needed the
> modification...
> 

> I'd suggest trying this driver on a different board with the same flash
> if you've got one. This would rule out possible hardware issue. On my
> Adder, the driver works so I can't reproduce the problem in our lab.
I tried 4 more boards.
I confirm the problem on one board with the same two flash chips
(AM29LV641DH). I also found two boards with mixed chips (one AM29LV641MH
and AM29LV641DH). One of those board has problem on erasing, no problem
on programming. The other board is fine. 

The problem did show up on the board with two AM29LV641MH. 

I have revised the driver to support port width from 8-bit to 64-bit,
chip width from 8-bit to 32-bit. Also, I modified the driver to poll DQ6
at the same address where the date is being written to. And I add the
polling DQ7, which is not enabled by default. With these modification,
all my boards passed testing.

By the way, here is the feedback from AMD, "It is a good practice to use
the exact address where data is being written to when using the "DQ6"
method, even though in theory you don't have to."

If you want to confirm, I can generate a patch. Wolfgang?

Regards,

York

  parent reply	other threads:[~2004-10-27 19:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-20 19:26 [U-Boot-Users] CFI driver York Sun
2004-10-20 19:59 ` Yuli Barcohen
2004-10-20 20:19 ` Yuli Barcohen
2004-10-20 20:40   ` York Sun
2004-10-20 21:21     ` York Sun
     [not found]       ` <16759.40840.186219.754326@astp0002.localdomain>
     [not found]         ` <1098369141.4502.18.camel@localhost.localdomain>
     [not found]           ` <16765.12175.401464.214322@astp0002.localdomain>
2004-10-27 19:55             ` York Sun [this message]
2004-10-27 20:37               ` Wolfgang Denk
     [not found] <E1CKMIE-00085P-Dl@sc8-sf-list1.sourceforge.net>
2004-10-21  3:06 ` Sam Song
2004-10-21  3:08 ` Sam Song
  -- strict thread matches above, loose matches on Subject: below --
2004-10-27 21:10 York Sun
2004-11-22 17:46 ` Jon Loeliger
2004-11-22 18:57   ` York Sun
2004-11-29 19:58     ` Jon Loeliger
2004-11-29 21:06       ` Wolfgang Denk
2005-04-03 20:47 Wolfgang Denk
2005-04-04 17:39 ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1098906900.7217.41.camel@localhost.localdomain \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox