From: Fabio Estevam <festevam@denx.de>
To: Frieder Schrempf <frieder@fris.de>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
u-boot@lists.denx.de, Heiko Thiery <heiko.thiery@gmail.com>,
Tom Rini <trini@konsulko.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Marek Vasut <marex@denx.de>
Subject: Re: [PATCH 1/2] pmic: pca9450: Add optional SD_VSEL GPIO for LDO5
Date: Thu, 23 Jun 2022 14:58:40 -0300 [thread overview]
Message-ID: <10d4b50271a72ed2d188bc2031ecdaf2@denx.de> (raw)
In-Reply-To: <20220623174215.299989-1-frieder@fris.de>
On 23/06/2022 14:42, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> LDO5 has two separate control registers. LDO5CTRL_L is used if the
> input signal SD_VSEL is low and LDO5CTRL_H if it is high.
> The current driver implementation only uses LDO5CTRL_H. To make this
> work on boards that have SD_VSEL connected to a GPIO, we add support
> for specifying an optional GPIO and setting it to high at probe time.
>
> In the future we might also want to add support for boards that have
> SD_VSEL set to a fixed low level. In this case we need to change the
> driver to be able to use the LDO5CTRL_L register.
>
> This is a port of the same change in the Linux kernel:
> 8c67a11bae88 ("regulator: pca9450: Add SD_VSEL GPIO for LDO5")
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Fabio Estevam <festevam@denx.de>
prev parent reply other threads:[~2022-06-23 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 17:42 [PATCH 1/2] pmic: pca9450: Add optional SD_VSEL GPIO for LDO5 Frieder Schrempf
2022-06-23 17:42 ` [PATCH 2/2] imx: kontron-sl-mx8mm: Enable PCA9450 regulator driver and fix SD card access Frieder Schrempf
2022-06-23 17:58 ` Fabio Estevam
2022-06-23 17:58 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10d4b50271a72ed2d188bc2031ecdaf2@denx.de \
--to=festevam@denx.de \
--cc=frieder.schrempf@kontron.de \
--cc=frieder@fris.de \
--cc=heiko.thiery@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=marex@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox