From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDDC8C43334 for ; Thu, 23 Jun 2022 17:58:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB6C3842DC; Thu, 23 Jun 2022 19:58:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1656007122; bh=9M8PH1/zL1D4iCGFGvH4BBS6QNAD1SToHBJjtArkNok=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mONWR6SHXtiv7UsyALkX1wywPl0O4pMoAGfKcYXQfBdisB1TNecIOTh7roq3Jc1yo A7LLcYtzkkYNaGDAWVoPo/y3wvTj8J7jlvPKZpD/UdyVZ2cxQzoUgMAammB4L7/kM3 hiNX+a905C3mQKUWZNGDIvyj/iDqg6NZwUEpIqjMvCtsExVxoAvwl69pRqT4BOiv2d F6IudWsz5dkTQKv9J7XuqwgUuH+fVCHWwmaq4y0xay9bIKPxIafghdsUhq5wHMDPTB w3Ux+IMijGBHEIzr+CRUt5uw/DabIlYsUNHAZ57h8PVfTdguzW0zAE4al4P26hFLND EFJjIriLTGqow== Received: from mail.denx.de (unknown [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: festevam@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 39195842AD; Thu, 23 Jun 2022 19:58:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1656007120; bh=9M8PH1/zL1D4iCGFGvH4BBS6QNAD1SToHBJjtArkNok=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m2AzMCN3jNByXrUZi9f7P6oUh4OCMa1LG/ZXPkCAtWdvXE0LaTllRdXR4vntxSpUQ pJ/0f8QshvhVfXAKXzDMwK+XXey+GaOwja3lox66uLyyV6NuFaEU3To3QJlSOwZ2uc qP7sIjxWfXE01XekLVVBfqmjjM0wznr5DR99lnBYOJ0n/vlQ5ex/OyBsGDnTiwqdfT 8Z8LD5fYBFqQLnLEnjNqqUdBeIbiYcd54P+ySg0aAzN/33bYNq+nyFzY0vfqLZ8IHl m62a3hD2pw0gk1JnVevL/ShlKuxrK4a4x5cf6KDnODiaZJGWoXc/Wxp9VQrob73X4e y8xeKnkxVGCZg== MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Jun 2022 14:58:40 -0300 From: Fabio Estevam To: Frieder Schrempf Cc: Jaehoon Chung , u-boot@lists.denx.de, Heiko Thiery , Tom Rini , Frieder Schrempf , Marek Vasut Subject: Re: [PATCH 1/2] pmic: pca9450: Add optional SD_VSEL GPIO for LDO5 In-Reply-To: <20220623174215.299989-1-frieder@fris.de> References: <20220623174215.299989-1-frieder@fris.de> Message-ID: <10d4b50271a72ed2d188bc2031ecdaf2@denx.de> X-Sender: festevam@denx.de User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 23/06/2022 14:42, Frieder Schrempf wrote: > From: Frieder Schrempf > > LDO5 has two separate control registers. LDO5CTRL_L is used if the > input signal SD_VSEL is low and LDO5CTRL_H if it is high. > The current driver implementation only uses LDO5CTRL_H. To make this > work on boards that have SD_VSEL connected to a GPIO, we add support > for specifying an optional GPIO and setting it to high at probe time. > > In the future we might also want to add support for boards that have > SD_VSEL set to a fixed low level. In this case we need to change the > driver to be able to use the LDO5CTRL_L register. > > This is a port of the same change in the Linux kernel: > 8c67a11bae88 ("regulator: pca9450: Add SD_VSEL GPIO for LDO5") > > Signed-off-by: Frieder Schrempf Reviewed-by: Fabio Estevam