From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 019DBC4332F for ; Mon, 17 Oct 2022 05:51:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B03E84F2B; Mon, 17 Oct 2022 07:51:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="EThPE8Cq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E4DAD84EED; Mon, 17 Oct 2022 07:51:05 +0200 (CEST) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 51BAA84F44 for ; Mon, 17 Oct 2022 07:50:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20221017055055epoutp021c362fea36c1af939311ef0f72677008~exU8BlqoD0425604256epoutp02Z for ; Mon, 17 Oct 2022 05:50:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20221017055055epoutp021c362fea36c1af939311ef0f72677008~exU8BlqoD0425604256epoutp02Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1665985855; bh=M4dC7bpUUVTRheLxb1R8MeqLOD8rnfrrSKOt/VLic5g=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=EThPE8CqYtzBxRcs53zAw5wX8eTrXg7KPYD6SBwCCODVEnuwjDB0fI8aae8ViGnCT ZFSgwEZd8OPwqnJu/W12RP9L4RfI7ehohFmWbG+F5eLgSbWl0gvCjZT+GelvZrkBn8 c8/ZHTl9mV4gBKWQdroUwf1Dp5L7xqUT19OD28zM= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20221017055054epcas1p3c11cd69eb760c324cc4215b8b90c8634~exU7qA-p12757627576epcas1p3N; Mon, 17 Oct 2022 05:50:54 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.36.144]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4MrR1T0vBNz4x9QH; Mon, 17 Oct 2022 05:50:53 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id B3.5A.07691.C3DEC436; Mon, 17 Oct 2022 14:50:52 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20221017055052epcas1p1f48294e9b4d281e0eea6d341900385ee~exU5btSnD0831908319epcas1p1E; Mon, 17 Oct 2022 05:50:52 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20221017055052epsmtrp1948ec5688835cecf68d03df76349eddf~exU5a5DSg2140321403epsmtrp1y; Mon, 17 Oct 2022 05:50:52 +0000 (GMT) X-AuditID: b6c32a38-8d6dba8000021e0b-a9-634ced3ce0c3 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id F3.BB.14392.C3DEC436; Mon, 17 Oct 2022 14:50:52 +0900 (KST) Received: from jh80chung01 (unknown [10.113.111.84]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20221017055052epsmtip1e2f68eef8c56e7f6acec23147651cc63~exU5HXLt31451714517epsmtip12; Mon, 17 Oct 2022 05:50:52 +0000 (GMT) From: =?ks_c_5601-1987?B?waTA58jG?= To: "'Simon Glass'" , "'U-Boot Mailing List'" Cc: "'Tom Rini'" , "'Andrew Scull'" , "'Heinrich Schuchardt'" , "'Marek Vasut'" , "'Mark Kettenis'" , "'Pavel Herrmann'" , "'Peng Fan'" , "'Stefan Roese'" , "'Ye Li'" In-Reply-To: <20221013122927.636867-22-sjg@chromium.org> Subject: RE: [PATCH v2 21/45] dm: blk: mmc: Tidy up some Makefile rules for SPL Date: Mon, 17 Oct 2022 14:50:51 +0900 Message-ID: <112201d8e1ec$6a760300$3f620900$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ks_c_5601-1987" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQJexruUiF8NTVnZFA8d7sH1UWaWzAIESTqCAyPBWtGs3QrVgA== Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA01TbUxbVRjOubcfF0a3S4vsrBLtbjrNiEDLWnYxoJsQdiOTsWw6oxl4194U hH6kt8W6xVkkNEBQh8qHxXXEQBRI5uwI67aQQXF8mNaEDYLOMQSWmALFDqVzw4ktFwz/nvd9 nyfned5zDoaKBwRSrNRgYcwGupwQxPJ6B/empWQFD2sUridKMhjuQcmhO0MoueioBKSnqgkh /+76i0+Ge3oBOXoxhJCNn10WksG+WiE52BgCpGPYCw5so1rtYzzK5RzhUVedU0Iq9KCIanNb qfn+LiHlv+sB1PdLHoTyr3yEFsa8VZZVwtBaxixjDBqjttSgyybyjxXnFKszFMoUZSa5n5AZ aD2TTeQeLkzJKy2PuCVkFXS5NdIqpFmWSHspy2y0WhhZiZG1ZBOMSVtuUptSWVrPWg26VANj eVGpUKSrI8R3ykoaWwOoyf207evZBoEdzCbWgRgM4io4NxPi1YFYTIx7AFy6WMXnimUAnWuT gCvCAF763Y9sStYa3EJu0Aegt+U2PzoQ4wEAu0NvRLEAz4L23oGIAMMS8Deh/+eCKB/FJxDo eejiRTkxOAl7+68JohwJfhQGaoTRNg/fA5vvPgFRLMIz4dT8JI/D8XD0y/vrGMXTYXv3BYTD z8Irwa9QzpsMXl++uW4nAX8Fjno/ARwnAbbWOtCoB4iPY7D+l2YeJ8iFg394N8QSOD/cI+Sw FAY+dQg5QRWAHe0DfK6oB/Bf+6SAY+2DNzo+31jLbnh19fzGcdvh0ko9P5oM4iJY4xBzFDm8 tRBANg+Yur/GPwcI55Zwzi3hnFvCObeEaAO8LpDImFi9jmGVJtX/960x6t1g/S0nkx5wPhhK 9QIEA14AMZRIEOkX8zVikZZ+/zRjNhabreUM6wXqyL4bUOlTGmPkMxgsxUpVpkKVkb5PRSoz lMROkb0lWSPGdbSFKWMYE2Pe1CFYjNSOpOl8I+KCHYf2J76cd/Pb1D3srz/5JONFdXn0TPVe uaL/oJZ+FCdrCp4YkYSH3zuenlSdpa88bfCdrSkSU6cWrK6JJn7qvdjww+V2ufyFU/bL/9x+ FcuTF5A9uSd7V56h7v3WLursC39wIdjdNlZF08Iz4iMrJw49qKd/oKW2seYz8cNzhbbM2ddb 4q75FGtnlZKFb2JXrNerqaPystzx1S/yZqb9w0mdN47o0YBW/xwyvauxynapoza5IufdqaRH x5tfO5BzbHnb41vPf9gmdnR+F7QNnQyvFm+f2GFp/nNmrvLj/INxd3yBx4uqnGm37u0ruwua Kmp+JF3xUmrXTpua4LEltDIZNbP0fyNyVWZUBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsWy7bCSnK7NW59kg+0nRCzeftvCbHHs1jFm izdtjYwWO5qnMVn8WPWF1eLblm2MFifXfWCymDppM7vF272d7BaHp35gtGg7fojRgdtjdsNF Fo95s06weOycdZfd48PHOI8Fm0o9Xh1Yxe5x9s4ORo+N73YweZz92sQcwBnFZZOSmpNZllqk b5fAlTF19kvmgk3SFYseTWRrYHwk1sXIySEhYCLxf+Im9i5GLg4hgd2MEpeXn2OFSEhJfH46 la2LkQPIFpY4fLgYJCwk8JxRoumjIojNJmAj0bDtIBOILSIQITH31yImkDnMAneZJJbNvccG MXQLo8TjjS/YQKo4BSwkth3YBTZUWMBfYsf2DJAwi4CqxPQ7fxlBbF4BS4m7r66zQNiCEidn PgGzmYEObTzcDWXLS2x/O4cZ4k4Fid2fjrJCHOEkcfJQHyNEjYjE7M425gmMwrOQjJqFZNQs JKNmIWlZwMiyilEytaA4Nz232LDAMC+1XK84Mbe4NC9dLzk/dxMjODa1NHcwbl/1Qe8QIxMH 4yFGCQ5mJRHe3DfeyUK8KYmVValF+fFFpTmpxYcYpTlYlMR5L3SdjBcSSE8sSc1OTS1ILYLJ MnFwSjUw9aqL6+6bpD45k6Fbvf3paeHkVcUyfTs0/Zu6WTQfr7ulPy124fs1wRz5KlcdCs9d Wc0zZ725QNHT0P4vyX6HGeIMRV/t2G5zcPX9mAXpqYxRO998M2utXlQ9IWlx6syGYlYem23v pvz5/1ypm6G9yNdT7H3wTfsj3VPu65Y8/fhzwgG52Y5bfjdpLDnf0zdxs4SddPzCw34eD4Vt FXb+zrgzoTNzT4iCiqDD0sOJ0rb6Bz3OHpvda5rY63/sS9r5uS1OZhlOf/Z2etxUqHwtr2AZ 7DaP56npGaOTe/bNfOsgcWjKm/de8yRZLXbsql554Z/GDDZ7weMLlDQaNz45cV44J/W1PMde 5+Lv0pONlViKMxINtZiLihMB+H2eFzwDAAA= X-CMS-MailID: 20221017055052epcas1p1f48294e9b4d281e0eea6d341900385ee X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20221013123032epcas1p19a8e17121d9b69e34340824eabd4cf48 References: <20221013122927.636867-1-sjg@chromium.org> <20221013122927.636867-22-sjg@chromium.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean > -----Original Message----- > From: Simon Glass [mailto:sjg@chromium.org] > Sent: Thursday, October 13, 2022 9:29 PM > To: U-Boot Mailing List > Cc: Tom Rini ; Simon Glass ; Andrew Scull > ; Heinrich Schuchardt ; Jaehoon Chung > ; Marek Vasut ; Mark Kettenis ; Pavel > Herrmann ; Peng Fan ; Stefan Roese ; Ye Li > > Subject: [PATCH v2 21/45] dm: blk: mmc: Tidy up some Makefile rules for SPL > > Use the correct SPL_TPL_ variable so that these features can be enabled in > TPL and VPL as needed. > > Disable it by default in TPL to avoid any code-size increase. No boards > are actually using it since the Makefile rules don't allow including > drivers/block/ with TPL_DM enabled. It can be manually enabled as needed. > > Signed-off-by: Simon Glass Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > Changes in v2: > - Disable TPL_BLK by default > > drivers/Makefile | 2 +- > drivers/block/Kconfig | 1 - > drivers/block/Makefile | 2 +- > drivers/mmc/Makefile | 2 +- > 4 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/Makefile b/drivers/Makefile > index 9d9f69a3c9a..a1700c819de 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0+ > > +obj-$(CONFIG_$(SPL_TPL_)BLK) += block/ > obj-$(CONFIG_$(SPL_TPL_)BOOTCOUNT_LIMIT) += bootcount/ > obj-$(CONFIG_$(SPL_TPL_)BUTTON) += button/ > obj-$(CONFIG_$(SPL_TPL_)CACHE) += cache/ > @@ -60,7 +61,6 @@ obj-$(CONFIG_SPL_USB_HOST) += usb/host/ > obj-$(CONFIG_OMAP_USB_PHY) += usb/phy/ > obj-$(CONFIG_SPL_SATA) += ata/ scsi/ > obj-$(CONFIG_SPL_LEGACY_BLOCK) += block/ > -obj-$(CONFIG_SPL_BLK) += block/ > obj-$(CONFIG_SPL_THERMAL) += thermal/ > > endif > diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig > index 707e2bcd238..e95da48bdc0 100644 > --- a/drivers/block/Kconfig > +++ b/drivers/block/Kconfig > @@ -37,7 +37,6 @@ config SPL_BLK > config TPL_BLK > bool "Support block devices in TPL" > depends on TPL_DM && BLK > - default y > help > Enable support for block devices, such as SCSI, MMC and USB > flash sticks. These provide a block-level interface which permits > diff --git a/drivers/block/Makefile b/drivers/block/Makefile > index f48d3e12140..19d9317c825 100644 > --- a/drivers/block/Makefile > +++ b/drivers/block/Makefile > @@ -3,7 +3,7 @@ > # (C) Copyright 2000-2007 > # Wolfgang Denk, DENX Software Engineering, wd@denx.de. > > -obj-$(CONFIG_$(SPL_)BLK) += blk-uclass.o > +obj-$(CONFIG_$(SPL_TPL_)BLK) += blk-uclass.o > > ifndef CONFIG_$(SPL_)BLK > obj-$(CONFIG_SPL_LEGACY_BLOCK) += blk_legacy.o > diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile > index 5d5104bbf1d..3a664c2ebbb 100644 > --- a/drivers/mmc/Makefile > +++ b/drivers/mmc/Makefile > @@ -10,7 +10,7 @@ ifdef CONFIG_$(SPL_TPL_)DM_MMC > obj-$(CONFIG_$(SPL_TPL_)BOOTSTD) += mmc_bootdev.o > endif > > -obj-$(CONFIG_$(SPL_)MMC_WRITE) += mmc_write.o > +obj-$(CONFIG_$(SPL_TPL_)MMC_WRITE) += mmc_write.o > obj-$(CONFIG_MMC_PWRSEQ) += mmc-pwrseq.o > obj-$(CONFIG_MMC_SDHCI_ADMA_HELPERS) += sdhci-adma.o > > -- > 2.38.0.rc1.362.ged0d419d3c-goog