From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>, u-boot@lists.denx.de
Cc: "Maxim Cournoyer" <maxim.cournoyer@savoirfairelinux.com>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Marek Behún" <kabel@kernel.org>, "Pali Rohár" <pali@kernel.org>,
"Quentin Schulz" <quentin.schulz@theobroma-systems.com>,
"Simon Glass" <sjg@chromium.org>, "Tom Rini" <trini@konsulko.com>
Subject: Re: [PATCH] doc: add texinfodocs and infodocs targets
Date: Sat, 17 Dec 2022 13:27:52 +0000 [thread overview]
Message-ID: <112c5967-ae51-7312-0534-9bb01d9ef404@gmx.de> (raw)
In-Reply-To: <20221217025137.2514-1-maxim.cournoyer@savoirfairelinux.com>
On 12/17/22 02:51, Maxim Cournoyer wrote:
> Sphinx supports generating Texinfo sources and Info documentation,
> which can be navigated easily and is convenient to search (via the
> indexed nodes or anchors, for example). This is basically the same as
> 1f050e904dd6f2955eecbd22031d912ccb2e7683, which was recently applied
> to the Linux kernel.
>
> Signed-off-by: Maxim Cournoyer <maxim.cournoyer@savoirfairelinux.com>
> ---
>
> Makefile | 2 +-
> doc/Makefile | 11 +++++++++++
> doc/media/Makefile | 3 ++-
> 3 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index de5746399a..597a8886c3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2372,7 +2372,7 @@ tcheck:
> # Documentation targets
> # ---------------------------------------------------------------------------
> DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs \
> - linkcheckdocs dochelp refcheckdocs
> + linkcheckdocs dochelp refcheckdocs texinfodocs infodocs
> PHONY += $(DOC_TARGETS)
> $(DOC_TARGETS): scripts_basic FORCE
> $(Q)$(MAKE) $(build)=doc $@
> diff --git a/doc/Makefile b/doc/Makefile
> index f5de65e927..62effd0fec 100644
> --- a/doc/Makefile
> +++ b/doc/Makefile
> @@ -69,6 +69,15 @@ quiet_cmd_sphinx = SPHINX $@ --> file://$(abspath $(BUILDDIR)/$3/$4)
> htmldocs:
> @+$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,html,$(var),,$(var)))
>
> +texinfodocs:
> + @$(srctree)/scripts/sphinx-pre-install --version-check
> + @+$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,texinfo,$(var),texinfo,$(var)))
> +
> +# Note: the 'info' Make target is generated by sphinx itself when
> +# running the texinfodocs target defined above.
> +infodocs: texinfodocs
> + $(MAKE) -C $(BUILDDIR)/texinfo info
> +
> linkcheckdocs:
> @$(foreach var,$(SPHINXDIRS),$(call loop_cmd,sphinx,linkcheck,$(var),,$(var)))
>
> @@ -109,6 +118,8 @@ cleandocs:
> dochelp:
> @echo ' U-Boot documentation in different formats from ReST:'
> @echo ' htmldocs - HTML'
> + @echo ' texinfodocs - Texinfo'
> + @echo ' infodocs - Info'
This does not work:
$ make infodocs
make[1]: ./scripts/sphinx-pre-install: No such file or directory
$ make texinfodocs
make[1]: ./scripts/sphinx-pre-install: No such file or directory
make[1]: *** [doc/Makefile:73: texinfodocs] Error 127
make: *** [Makefile:2378: texinfodocs] Error 2
@Tom:
Should we add a build step for each of the new targets to
.gitlab-ci.yml and .azure-pipelines.yml?
Best regards
Heinrich
> @echo ' latexdocs - LaTeX'
> @echo ' pdfdocs - PDF'
> @echo ' epubdocs - EPUB'
> diff --git a/doc/media/Makefile b/doc/media/Makefile
> index b9b43a34c3..9b32258696 100644
> --- a/doc/media/Makefile
> +++ b/doc/media/Makefile
> @@ -22,10 +22,11 @@ $(BUILDDIR)/linker_lists.h.rst: ${API}/linker_lists.h ${PARSER} $(SRC_DIR)/linke
>
> # Media build rules
>
> -.PHONY: all html epub xml latex
> +.PHONY: all html texinfo epub xml latex
>
> all: $(IMGDOT) $(BUILDDIR) ${TARGETS}
> html: all
> +texinfo: all
> epub: all
> xml: all
> latex: $(IMGPDF) all
>
> base-commit: 9bd3d354a1a0712ac27c717df9ad60566b0406ee
next prev parent reply other threads:[~2022-12-17 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 2:51 [PATCH] doc: add texinfodocs and infodocs targets Maxim Cournoyer
2022-12-17 13:27 ` Heinrich Schuchardt [this message]
2022-12-17 16:02 ` Maxim Cournoyer
2022-12-17 19:36 ` Heinrich Schuchardt
2022-12-19 1:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=112c5967-ae51-7312-0534-9bb01d9ef404@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=kabel@kernel.org \
--cc=maxim.cournoyer@gmail.com \
--cc=maxim.cournoyer@savoirfairelinux.com \
--cc=pali@kernel.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox