From: Alex BASTOS <alebas@televes.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Re: Problem with the cfi flash driver with ax8/x16 flash configuredinx8 mode.
Date: Fri, 13 Jan 2006 13:29:17 +0100 [thread overview]
Message-ID: <1137155357.43c79d1db02da@webmail.televes.com:443> (raw)
In-Reply-To: <43C766C4.4030302@aotek.es>
> What "shifting the commands" means ? I though the problem was with the
> addresses.
Sorry, mis-speaking. Shifting the addresses, I mean. ;)
>
> #define AMD_ADDR_ERASE_START ((info->portwidth == FLASH_CFI_8BIT) ?
> 0xAAA : 0x555)
> #define AMD_ADDR_START ((info->portwidth ==
> FLASH_CFI_8BIT) ? 0xAAA : 0x555)
> #define AMD_ADDR_ACK ((info->portwidth ==
> FLASH_CFI_8BIT) ? 0x555 : 0x2AA)
>
> I think is cleaner to change one define than the code. What do you think?
>
For me it's OK. I have no preference about how to do it.
I think, at the end, it will be Wolfgang or Tolunay Orkun
who will choose.
Best regards,
Alex
next prev parent reply other threads:[~2006-01-13 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-13 7:27 [U-Boot-Users] Re: Problem with the cfi flash driver with a x8/x16 flash confi guredinx8 mode Bastos Fernandez Alexandre
2006-01-13 8:37 ` [U-Boot-Users] Re: Problem with the cfi flash driver with ax8/x16 flash configuredinx8 mode Txema Lopez
2006-01-13 12:29 ` Alex BASTOS [this message]
2006-01-13 21:58 ` Tolunay Orkun
2006-01-13 23:17 ` Wolfgang Denk
2006-02-28 16:47 ` [U-Boot-Users] Re: Problem with the cfi flash driver with a x8/x16 flash confi guredinx8 mode Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1137155357.43c79d1db02da@webmail.televes.com:443' \
--to=alebas@televes.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox