From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex BASTOS Date: Fri, 13 Jan 2006 13:29:17 +0100 Subject: [U-Boot-Users] Re: Problem with the cfi flash driver with ax8/x16 flash configuredinx8 mode. In-Reply-To: <43C766C4.4030302@aotek.es> References: <51DB8827D393D411BB69003048003F4601B1C284@tvesntr> <43C766C4.4030302@aotek.es> Message-ID: <1137155357.43c79d1db02da@webmail.televes.com:443> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > What "shifting the commands" means ? I though the problem was with the > addresses. Sorry, mis-speaking. Shifting the addresses, I mean. ;) > > #define AMD_ADDR_ERASE_START ((info->portwidth == FLASH_CFI_8BIT) ? > 0xAAA : 0x555) > #define AMD_ADDR_START ((info->portwidth == > FLASH_CFI_8BIT) ? 0xAAA : 0x555) > #define AMD_ADDR_ACK ((info->portwidth == > FLASH_CFI_8BIT) ? 0x555 : 0x2AA) > > I think is cleaner to change one define than the code. What do you think? > For me it's OK. I have no preference about how to do it. I think, at the end, it will be Wolfgang or Tolunay Orkun who will choose. Best regards, Alex