Re: [PATCH v3 11/19] bootmeth_efi: Check the filename-allocation in the network path

[Heinrich Schuchardt <xypron.glpk@gmx.de>]

On 11/4/24 18:51, Simon Glass wrote:
> If the filename cannot be set we should give up. Add the missing error
> check.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Change the tag to bootmeth_efi
>
>   boot/bootmeth_efi.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c
> index e8109e19bcb..1ff8788ebeb 100644
> --- a/boot/bootmeth_efi.c
> +++ b/boot/bootmeth_efi.c
> @@ -269,6 +269,8 @@ static int distro_efi_read_bootflow_net(struct bootflow *bflow)
>   	if (!bootfile_name)
>   		return log_msg_ret("bootfile_name", ret);
>   	bflow->fname = strdup(bootfile_name);
> +	if (!bflow->fname)
> +		return log_msg_ret("fi0", -ENOMEM);

How could we hope that a user understands a cryptic message
"fi0: returning err=-12"?

Please, write a message that is user readable.

log_err("Out of memory");

Best regards

Heinrich


>
>   	/* do the hideous EFI hack */
>   	efi_set_bootdev("Net", "", bflow->fname, map_sysmem(addr, 0),