From: Marek Vasut <marex@denx.de>
To: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Adam Ford <aford173@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Igor Opaniuk <igor.opaniuk@gmail.com>,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Oliver Graute <oliver.graute@kococonnector.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Philippe Schenker <philippe.schenker@toradex.com>,
Simon Glass <sjg@chromium.org>, Tero Kristo <kristo@kernel.org>
Subject: Re: [PATCH 6/8] configs: toradex: add default rootpath
Date: Thu, 22 Jul 2021 20:06:32 +0200 [thread overview]
Message-ID: <116c8293-ffde-ffcb-d857-2c45877a75a1@denx.de> (raw)
In-Reply-To: <CAGgjyvHaSKt-iMtMuah_q+n=RF8XnO0_kmJA3oNMmkgAMzcQbA@mail.gmail.com>
On 7/22/21 6:32 PM, Oleksandr Suvorov wrote:
> Hello Marek,
>
> On Thu, Jul 22, 2021 at 7:08 PM Marek Vasut <marex@denx.de> wrote:
>>
>> On 7/22/21 5:49 PM, Oleksandr Suvorov wrote:
>>
>> [...]
>>
>>> diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
>>> index b04a03f76d..5a90e03edb 100644
>>> --- a/include/configs/apalis-imx8.h
>>> +++ b/include/configs/apalis-imx8.h
>>> @@ -24,6 +24,7 @@
>>> #define CONFIG_IPADDR 192.168.10.2
>>> #define CONFIG_NETMASK 255.255.255.0
>>> #define CONFIG_SERVERIP 192.168.10.1
>>> +#define CONFIG_ROOTPATH "/srv/nfs"
>>
>> Rather, all this should be removed, since all these IP addresses and
>> root path settings are invalid for most places where the system will be
>> used. The user should define their own. It is not recommended to hard
>> code this in board config.
>
> Is it acceptable to move this stuff to Toradex Kconfigs as default values?
The general recommendation is to not set such default values at all,
just let the user configure what they need.
next prev parent reply other threads:[~2021-07-22 18:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 15:49 [PATCH 0/8] Patches for Toradex boards Oleksandr Suvorov
2021-07-22 15:49 ` [PATCH 1/8] board: colibri_vf: synchronize/improve memory options Oleksandr Suvorov
2021-07-22 15:49 ` [PATCH 2/8] board: colibri_imx7: use SDP if USB serial downloader has been used Oleksandr Suvorov
2021-07-22 15:49 ` [PATCH 3/8] board: toradex: make USB PID from config block optional Oleksandr Suvorov
2021-07-22 15:49 ` [PATCH 4/8] board: colibri-imx8x: update building documentation Oleksandr Suvorov
2021-07-22 15:49 ` [PATCH 5/8] board: colibri_imx6: add board_fit_config_name_match to support FIT in SPL Oleksandr Suvorov
2021-07-22 15:49 ` [PATCH 6/8] configs: toradex: add default rootpath Oleksandr Suvorov
2021-07-22 15:49 ` [PATCH 7/8] board: colibri_vf: fix compiling warning Oleksandr Suvorov
2021-07-22 15:49 ` [PATCH 8/8] board: apalis-tk1: launch toradex easy installer in usb recovery Oleksandr Suvorov
2021-07-22 16:07 ` [PATCH 6/8] configs: toradex: add default rootpath Marek Vasut
2021-07-22 16:32 ` Oleksandr Suvorov
2021-07-22 18:06 ` Marek Vasut [this message]
2021-07-22 18:10 ` Oleksandr Suvorov
2021-07-22 18:18 ` Marek Vasut
2021-07-22 18:29 ` Oleksandr Suvorov
2021-07-22 17:40 ` [PATCH 1/8] board: colibri_vf: synchronize/improve memory options Tom Rini
2021-07-23 6:09 ` Oleksandr Suvorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=116c8293-ffde-ffcb-d857-2c45877a75a1@denx.de \
--to=marex@denx.de \
--cc=aford173@gmail.com \
--cc=festevam@gmail.com \
--cc=igor.opaniuk@gmail.com \
--cc=kristo@kernel.org \
--cc=oleksandr.suvorov@toradex.com \
--cc=oleksandr_andrushchenko@epam.com \
--cc=oliver.graute@kococonnector.com \
--cc=patrick.delaunay@foss.st.com \
--cc=philippe.schenker@toradex.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox