From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D60C63797 for ; Thu, 22 Jul 2021 18:06:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38BFC604AC for ; Thu, 22 Jul 2021 18:06:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38BFC604AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0C39F82C49; Thu, 22 Jul 2021 20:06:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626977195; bh=vF5c6hDxo/5jXxpeEYF2IW5XSYlIkrm68v9lNZBeo58=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VcwLURVX4qLRz6VWRn5dcIGjfG9Abu9n0SCCR5w3Tsl7tQAwSj1g1UVc9LMa6B8or ty3sw+hifubOedswnBfqfD+g59+rqGe6YS8rjtu11W8U+wH9oTAsWcHmQLPCPZ5TxX uDPhRwNpBsmrM5IPezxvtvQkAKcoOd3RnUaMxMcjMr5r+xu5G+lwMTBaLMNU+2tzcQ Vj8TfHQs87LtNzMsLqOLirZ/4XGNhX1mawLBtYj8JknM1YbmeDBpiL4VTKH3aowOmz xHXcOxjy4Y4przTfyq6bro9SqmL/9Bsr4jZ3ZZknopoVBwhGq2AOcUH/NOQLmTCN0L 0uqKVYBv9wKpw== Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id CC92D8297D; Thu, 22 Jul 2021 20:06:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626977193; bh=vF5c6hDxo/5jXxpeEYF2IW5XSYlIkrm68v9lNZBeo58=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=mSBw7exTZkYWB4JvbcEAHAs5NQKJ315Vs3UuHVQGJyWEcDediVpHrp0N1lKZuoUMh kU529fIn67L+0oL0jEXKKrjOQKn77VHo0wu24DZHVctHEwVaK+1wHPY0Wb+F152NjH +u9mNrOpYG5CLsAYntPhXfFP19AwutTL83hIT5/SP4RiQfmeF0577k6qkVHti7bFUb meaDeELzIWvN8MbioRYg0Ke1jQTVZsUxw+TWAkUHGjdzn1KkoT78Xgzen374JNhswP FkCWDgAYGlXhF1ttR+HCeYDiokxXF8ElUBibBe8r9QF9Xa5SjnABe6iSs4WCDaVFDD 31R5E9vFRWPGw== Subject: Re: [PATCH 6/8] configs: toradex: add default rootpath To: Oleksandr Suvorov Cc: U-Boot Mailing List , Adam Ford , Fabio Estevam , Igor Opaniuk , Oleksandr Andrushchenko , Oliver Graute , Patrick Delaunay , Philippe Schenker , Simon Glass , Tero Kristo References: <20210722154943.127775-1-oleksandr.suvorov@toradex.com> <20210722154943.127775-2-oleksandr.suvorov@toradex.com> <20210722154943.127775-3-oleksandr.suvorov@toradex.com> <20210722154943.127775-4-oleksandr.suvorov@toradex.com> <20210722154943.127775-5-oleksandr.suvorov@toradex.com> <20210722154943.127775-6-oleksandr.suvorov@toradex.com> <20210722154943.127775-7-oleksandr.suvorov@toradex.com> From: Marek Vasut Message-ID: <116c8293-ffde-ffcb-d857-2c45877a75a1@denx.de> Date: Thu, 22 Jul 2021 20:06:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/22/21 6:32 PM, Oleksandr Suvorov wrote: > Hello Marek, > > On Thu, Jul 22, 2021 at 7:08 PM Marek Vasut wrote: >> >> On 7/22/21 5:49 PM, Oleksandr Suvorov wrote: >> >> [...] >> >>> diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h >>> index b04a03f76d..5a90e03edb 100644 >>> --- a/include/configs/apalis-imx8.h >>> +++ b/include/configs/apalis-imx8.h >>> @@ -24,6 +24,7 @@ >>> #define CONFIG_IPADDR 192.168.10.2 >>> #define CONFIG_NETMASK 255.255.255.0 >>> #define CONFIG_SERVERIP 192.168.10.1 >>> +#define CONFIG_ROOTPATH "/srv/nfs" >> >> Rather, all this should be removed, since all these IP addresses and >> root path settings are invalid for most places where the system will be >> used. The user should define their own. It is not recommended to hard >> code this in board config. > > Is it acceptable to move this stuff to Toradex Kconfigs as default values? The general recommendation is to not set such default values at all, just let the user configure what they need.