From: Zang Roy-r61911 <tie-fei.zang@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch] Fix NC650 nand support
Date: 24 Apr 2007 14:32:58 +0800 [thread overview]
Message-ID: <1177396378.31559.21.camel@localhost.localdomain> (raw)
In-Reply-To: <m2zm4z2qla.fsf@sowhat.denx.de>
On Mon, 2007-04-23 at 21:00, Detlev Zundel wrote:
> Hi Roy,
[snip]
> >> > while doing this noticed that the whole fixup only works because
> we
> >> > have a maximum of one fixup entry (./drivers/tsi108_pci.c, I
> cannot
> >> > find any user of addr_probe anywhere).
> > Tsi108/9 pci config read will introduce a exception. I do not see
> other
> > exception after code relocation.
> >
> >> Otherwise the sorting of the
> >> > table is missing and thus the searching with a bisecting
> algorithm
> >> > will not work as is.
> > Why?
>
> As I said, the search algorithm only works with a sorted table - just
> what "sort_main_extable" does in Linux. To be honest I did not look
> too hard but I couldn't find anything similar in U-Boot so the table
> will be unsorted and thus very likely fail if more entries are added.
>
Unsorted table will induce error for more entries.
Until now, I can only see tsi108_pci.c adds exception item for the
exception table. Other boards have empty addr_probe. They are commented
out.
> So either sorting the table at some point or instead doing a linear
> search would fix the problems.
I prefer the second. I will do some test on my board and give the patch.
Thanks.
Roy
prev parent reply other threads:[~2007-04-24 6:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 10:07 [U-Boot-Users] [patch] Fix NC650 nand support Detlev Zundel
2007-04-20 11:38 ` Stefan Roese
2007-04-20 13:53 ` Wolfgang Denk
2007-04-20 15:14 ` Detlev Zundel
2007-04-20 15:49 ` Wolfgang Denk
2007-04-22 23:52 ` Zang Roy-r61911
2007-04-23 13:00 ` Detlev Zundel
2007-04-24 6:32 ` Zang Roy-r61911 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1177396378.31559.21.camel@localhost.localdomain \
--to=tie-fei.zang@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox