[U-Boot-Users] [PATCH] Fix memory initialization on MPC8349E-mITX

[U-Boot-Users] [PATCH] Fix memory initialization on MPC8349E-mITX

[Timur Tabi]

Define CFG_DDR_SDRAM_CLK_CNTL for the MPC8349E-mITX and MPC8349E-mITX-GP.
This allows ddr->sdram_clk_cntl to be properly initialized.  This is necessary
on some ITX boards, notably those with a revision 3.1 CPU.

Also change spd_sdram() in cpu/mpc83xx/spd_sdram.c to not write anything into
ddr->sdram_clk_cntl if CFG_DDR_SDRAM_CLK_CNTL is not defined.

Signed-off-by: Timur Tabi <timur@freescale.com>
---

This patch fixes bug 517 and fixes problems with some MPC8349E-mITX boards.
It's been tested on all 83xx platforms that use SPD.

 board/mpc8349itx/mpc8349itx.c |    3 +--
 cpu/mpc83xx/spd_sdram.c       |    5 -----
 include/configs/MPC8349ITX.h  |    3 +++
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/board/mpc8349itx/mpc8349itx.c b/board/mpc8349itx/mpc8349itx.c
index 2b3ded1..178b1d3 100644
--- a/board/mpc8349itx/mpc8349itx.c
+++ b/board/mpc8349itx/mpc8349itx.c
@@ -80,8 +80,7 @@ int fixed_sdram(void)
 	im->ddr.sdram_interval =
 	    (0x0410 << SDRAM_INTERVAL_REFINT_SHIFT) | (0x0100 <<
 						       SDRAM_INTERVAL_BSTOPRE_SHIFT);
-	im->ddr.sdram_clk_cntl =
-	    DDR_SDRAM_CLK_CNTL_SS_EN | DDR_SDRAM_CLK_CNTL_CLK_ADJUST_05;
+	im->ddr.sdram_clk_cntl = CFG_DDR_SDRAM_CLK_CNTL;
 
 	udelay(200);
 
diff --git a/cpu/mpc83xx/spd_sdram.c b/cpu/mpc83xx/spd_sdram.c
index d9b8753..2f5f9a3 100644
--- a/cpu/mpc83xx/spd_sdram.c
+++ b/cpu/mpc83xx/spd_sdram.c
@@ -693,11 +693,6 @@ long int spd_sdram()
 
 #ifdef CFG_DDR_SDRAM_CLK_CNTL	/* Optional platform specific value */
 	ddr->sdram_clk_cntl = CFG_DDR_SDRAM_CLK_CNTL;
-#else
-	/* SS_EN = 0, source synchronous disable
-	 * CLK_ADJST = 0, MCK/MCK# is launched aligned with addr/cmd
-	 */
-	ddr->sdram_clk_cntl = 0x00000000;
 #endif
 	debug("DDR:sdram_clk_cntl=0x%08x\n", ddr->sdram_clk_cntl);
 
diff --git a/include/configs/MPC8349ITX.h b/include/configs/MPC8349ITX.h
index 37bbfb3..906339e 100644
--- a/include/configs/MPC8349ITX.h
+++ b/include/configs/MPC8349ITX.h
@@ -154,6 +154,9 @@
 #define CFG_MEMTEST_START	0x1000		/* memtest region */
 #define CFG_MEMTEST_END		0x2000
 
+#define CFG_DDR_SDRAM_CLK_CNTL	(DDR_SDRAM_CLK_CNTL_SS_EN | \
+				DDR_SDRAM_CLK_CNTL_CLK_ADJUST_05)
+
 #ifdef CONFIG_HARD_I2C
 #define CONFIG_SPD_EEPROM		/* use SPD EEPROM for DDR setup*/
 #endif
-- 
1.5.0.2.260.g2eb065

[U-Boot-Users] [PATCH] Fix memory initialization on MPC8349E-mITX

[Wolfgang Denk]

In message <117795959029-git-send-email-timur@freescale.com> you wrote:
>
> This patch fixes bug 517 and fixes problems with some MPC8349E-mITX boards.
> It's been tested on all 83xx platforms that use SPD.

Please use a more meaningful patch description. You may have a way to
check what "bug 517" means, but I don't.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,    CEO: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you are afraid of loneliness, don't marry."             - Chekhov

[U-Boot-Users] [PATCH] Fix memory initialization on MPC8349E-mITX

[Timur Tabi]

Wolfgang Denk wrote:
> In message <117795959029-git-send-email-timur@freescale.com> you wrote:
>> This patch fixes bug 517 and fixes problems with some MPC8349E-mITX boards.
>> It's been tested on all 83xx platforms that use SPD.
> 
> Please use a more meaningful patch description. You may have a way to
> check what "bug 517" means, but I don't.

That wasn't a description, that was a comment.  It's located under the ---, so it won't 
appear in the git log.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

[U-Boot-Users] [PATCH] Fix memory initialization on MPC8349E-mITX

[Benedict, Michael]

Thank you Timur.

Acked-by: Michael Benedict <MBenedict@twacs.com>

[U-Boot-Users] [PATCH] Fix memory initialization on MPC8349E-mITX

[Wolfgang Denk]

In message <46364B86.8050405@freescale.com> you wrote:
> Wolfgang Denk wrote:
> > In message <117795959029-git-send-email-timur@freescale.com> you wrote:
> >> This patch fixes bug 517 and fixes problems with some MPC8349E-mITX boards.
> >> It's been tested on all 83xx platforms that use SPD.
> > 
> > Please use a more meaningful patch description. You may have a way to
> > check what "bug 517" means, but I don't.
> 
> That wasn't a description, that was a comment.  It's located under the ---, so it won't 
> appear in the git log.

Please use a more meaningful comment, then.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,    CEO: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Like winter snow on summer lawn, time past is time gone.

[U-Boot-Users] [PATCH] Fix memory initialization on MPC8349E-mITX

[Kim Phillips]

On Mon, 30 Apr 2007 15:16:06 -0500
"Benedict, Michael" <MBenedict@twacs.com> wrote:

> Thank you Timur.
> 
> Acked-by: Michael Benedict <MBenedict@twacs.com>
> 
applied, thank you.

Kim