From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A76D0EB64DC for ; Wed, 19 Jul 2023 02:17:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BB31B866D4; Wed, 19 Jul 2023 04:17:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.b="vYKb4uF9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 65513866F7; Wed, 19 Jul 2023 04:17:07 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5B81D86671 for ; Wed, 19 Jul 2023 04:17:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heinrich.schuchardt@canonical.com Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id E7E8F3F206 for ; Wed, 19 Jul 2023 02:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1689733024; bh=hHdJseQdsmNBm4sqYAxTcIg0Kt5ZDGsJLbHypnMJPIw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vYKb4uF9Q+bWl8yru+WkzVErpHJ61JvcTiFXUmvuKGkc3shNF1hyGN2VtWUl0WGKk i9TlV2n267hkj18pa2k/G45wVPjZ+qYMhkN9pRvWy1XkQDo/9KS4sJ5bH8qPNQJ9DK QX2VGA9qEaoocLA2025eG7ggGpAA6HTeFy6B/WSihbJDw+Wvc2dXo5fReoE9PVkd1O iueec0GaQ0CJjcmuah4/hlCMs42IWdFUaDx+6ZxAtiiVMFyXMkm2k4jCPWUmNEujqD RF3wbgT4VyTXWJmI4jYKubS3/4D6b5ZgQDVEGt6agjCZoZc7xm0gzuNBrgCu2FdDsh iTEeMRs/ONWaw== Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fa979d0c32so36479025e9.2 for ; Tue, 18 Jul 2023 19:17:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689733019; x=1692325019; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hHdJseQdsmNBm4sqYAxTcIg0Kt5ZDGsJLbHypnMJPIw=; b=ZQAJsVZitXoHPxxE0m6jlH5WKzsZ52b0K7YeneiXxlFE37AJB9mXpGQYm+NmknHQRy bFA9DtbNYpvTInLIDu2c0gBqvQHIRMa2tq1Z+kOoiMIMavkJXcDsFjlqJKMoiKY1OAN5 Aq3CRDHkr73C+zAV3HTEoyZ7UDQMRO1oWBN8ttppxKk6mR72cCUDqr/cDymZjv9CTj7z ZwBXRLGDZhxcHME0zDBA3HD5z61+c4wxulaO84/ILvrHwwH/n9cOrznDpp9QaLDBBiKI DDXIxpAtGfsvd6XIJw1sekwUb6rl81Egss5cQjb15G5O7Z+2Noya/r3KaE5jT/ac0xuJ 4t5A== X-Gm-Message-State: ABy/qLZbFrtQJH5bU7YiHeNSbTKjuyJ/AQFOk4YyRER4BwXIZVmCBZ7f cI8OzFOhJoAntwR+JZG5bokUo8GMXSH/OyzpaCgn8jf7PkBj9O5r79URgsUuOH/N90csEUke5r2 uL5iHnu6/Wr6KKtUSoeXbfE1hDXoE30A= X-Received: by 2002:adf:df0c:0:b0:315:93a1:c733 with SMTP id y12-20020adfdf0c000000b0031593a1c733mr15104906wrl.20.1689733019071; Tue, 18 Jul 2023 19:16:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlFaMs0S30W2s1DSREfUAA/KF3Lmy/M9yT0TGnCJ5z2rm4U0d/nW4aeVzsfSErs/2xLpGz4RdQ== X-Received: by 2002:adf:df0c:0:b0:315:93a1:c733 with SMTP id y12-20020adfdf0c000000b0031593a1c733mr15104895wrl.20.1689733018724; Tue, 18 Jul 2023 19:16:58 -0700 (PDT) Received: from [192.168.123.94] (ip-084-119-033-219.um24.pools.vodafone-ip.de. [84.119.33.219]) by smtp.gmail.com with ESMTPSA id d15-20020adff84f000000b00313f9085119sm3851238wrq.113.2023.07.18.19.16.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 19:16:58 -0700 (PDT) Message-ID: <11919cfa-893b-0e85-05ff-3516fa05a447@canonical.com> Date: Wed, 19 Jul 2023 04:17:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/1] part: eliminate part_get_info_by_name_type() To: Simon Glass Cc: Tom Rini , Stefan Herbrechtsmeier , Heiko Schocher , Tobias Waldekranz , Kever Yang , u-boot@lists.denx.de, "Andrew F . Davis" References: <20230716113444.23238-1-heinrich.schuchardt@canonical.com> Content-Language: en-US From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 7/19/23 03:08, Simon Glass wrote: > Hi Heinrich, > > On Sun, 16 Jul 2023 at 05:34, Heinrich Schuchardt > wrote: >> >> Since commit 56670d6fb83f ("disk: part: use common api to lookup part >> driver") part_get_info_by_name_type() ignores the part_type parameter >> used to restrict the partition table type. >> >> omap_mmc_get_part_size() and part_get_info_by_name() are the only >> consumers. >> >> omap_mmc_get_part_size() calls with part_type = PART_TYPE_EFI because at >> the time of implementation a speed up could be gained by passing the >> partition table type. After 5 years experience without this restriction >> it looks safe to keep it that way. >> >> part_get_info_by_name() uses PART_TYPE_ALL. >> >> Move the logic of part_get_info_by_name_type() to part_get_info_by_name() >> and replace the function in omap_mmc_get_part_size(). >> >> Fixes: 56670d6fb83f ("disk: part: use common api to lookup part driver") >> Signed-off-by: Heinrich Schuchardt >> --- >> arch/arm/mach-omap2/utils.c | 3 +-- >> disk/part.c | 10 ++-------- >> include/part.h | 23 ----------------------- >> 3 files changed, 3 insertions(+), 33 deletions(-) > > That explains the strange behaviour I saw when fiddling with this a > month or so back, thanks. > > Reviewed-by: Simon Glass > > Is there a test to update for this? Thanks for reviewing. As we don't change any existing behavior there is no test to update. Best regards Heinrich