From: Jon Loeliger <jdl@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] PPC4xx: Add Ethernet 1000BASE-X support for PPC4xx
Date: Mon, 29 Oct 2007 14:14:50 -0500 [thread overview]
Message-ID: <1193685290.1462.19.camel@ld0161-tx32> (raw)
In-Reply-To: <47262967.8070307@arlinx.com>
On Mon, 2007-10-29 at 13:41, Larry Johnson wrote:
> Would it be better to run Lindent on the original files, post those as
> changes, and then post a second patch with the new material?
In my opinion, yes, please.
> BTW, I've noticed that the "Lindent -pcs" format is used inconsistently
> within files. Since I'm also making changes in Linux, it's hard to
> remember whether to type "foo(bar);" or "foo (bar);",
In my opinion, "foo (bar)" is bad style, and I prefer
the Linux form, "foo(bar)".
jdl
next prev parent reply other threads:[~2007-10-29 19:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 17:00 [U-Boot-Users] [PATCH] PPC4xx: Add Ethernet 1000BASE-X support for PPC4xx Larry Johnson
2007-10-29 17:33 ` Ben Warren
2007-10-29 18:41 ` Larry Johnson
2007-10-29 19:14 ` Jon Loeliger [this message]
2007-10-29 19:30 ` Stefan Roese
2007-10-29 19:43 ` Larry Johnson
2007-10-29 19:37 ` Ben Warren
2007-10-29 20:26 ` Wolfgang Denk
2007-10-29 20:25 ` Wolfgang Denk
2007-10-29 21:36 ` Larry Johnson
2007-10-29 19:33 ` Stefan Roese
2007-10-29 20:26 ` Ben Warren
2007-10-29 22:01 ` Larry Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193685290.1462.19.camel@ld0161-tx32 \
--to=jdl@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox