public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Zang Roy-r61911 <tie-fei.zang@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add ULi 526x Ethernet driver support in	U-boot
Date: 01 Nov 2007 17:04:16 +0800	[thread overview]
Message-ID: <1193907855.19316.3.camel@localhost.localdomain> (raw)
In-Reply-To: <4728A015.1080707@qstreams.com>

On Wed, 2007-10-31 at 23:32, Ben Warren wrote:
> Hi Roy,
> 
> This patch doesn't apply to top-of tree. Some reasons are below:
> 
> Zang Roy-r61911 wrote:
> > From: Roy Zang <tie-fei.zang@freescale.com>
> >
> > Add ULi 526x Ethernet driver support in U-boot.
> > Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> > ---
> > It has been tested on MPC8610HPCD board.
> > Any feedback welcome.
> >  drivers/Makefile  |    2 +-
> >  drivers/uli526x.c | 1009
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  net/eth.c         |    4 +
> >  3 files changed, 1014 insertions(+), 1 deletions(-)
> >  create mode 100644 drivers/uli526x.c
> >
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index 3ee6312..08e139b 100755
> > -- a/drivers/Makefile
> >   
> My version of git (1.5.2.5) yaks at the '--' instead of '---'. All
> diffs 
> in your patch are this way
It is strange. Maybe it is caused by forward under evolution? 
Any way, I will regenerate the patch.
> > +++ b/drivers/Makefile
> > @@ -38,7 +38,7 @@ COBJS       = 3c589.o 5701rls.o ali512x.o at45.o
> ata_piix.o atmel_usart.o \
> >         omap24xx_i2c.o pci.o pci_auto.o pci_indirect.o \
> >         pcnet.o plb2800_eth.o \
> >         ps2ser.o ps2mult.o pc_keyb.o \
> > -       rtl8019.o rtl8139.o rtl8169.o \
> > +       rtl8019.o rtl8139.o rtl8169.o uli526x.o\
> >   
> Top-of tree has some different driver entries.
> Please re-submit after fixing these errors.
> 
> The patch itself looks reasonably sound, although I didn't know
> anybody 
> was making this chip any more.
Mpc8610hpcd board is using it.
The board users can benefit from the code.
I have some improvement of the driver. I will submit it again.
Roy

  reply	other threads:[~2007-11-01  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25  6:12 [U-Boot-Users] [PATCH] Add ULi 526x Ethernet driver support in U-boot Zang Roy-r61911
2007-10-31 11:32 ` [U-Boot-Users] [PATCH] Add ULi 526x Ethernet driver support inU-boot Zang Roy-r61911
2007-10-31 13:49   ` Ben Warren
2007-10-31 15:32 ` [U-Boot-Users] [PATCH] Add ULi 526x Ethernet driver support in U-boot Ben Warren
2007-11-01  9:04   ` Zang Roy-r61911 [this message]
2007-11-01  9:13   ` Zang Roy-r61911

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1193907855.19316.3.camel@localhost.localdomain \
    --to=tie-fei.zang@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox