From: Zang Roy-r61911 <tie-fei.zang@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config
Date: 14 Nov 2007 19:47:12 +0800 [thread overview]
Message-ID: <1195040831.3571.7.camel@localhost.localdomain> (raw)
In-Reply-To: <473A1914.7050304@qstreams.com>
On Wed, 2007-11-14 at 05:37, Ben Warren wrote:
> Jon Loeliger wrote:
> > From: Roy Zang <tie-fei.zang@freescale.com>
> >
> > Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> > Acked-by: Jon Loeliger <jdl@freescale.com>
> > ---
> > include/configs/MPC8610HPCD.h | 8 ++++----
> > 1 files changed, 4 insertions(+), 4 deletions(-)
> >
> <snip>
> > #define CONFIG_EEPRO100
> > #define CONFIG_TULIP
> > +#ifdef CONFIG_TULIP
> > +#define CONFIG_ETHADDR 00:E0:0C:00:00:01
> >
> Do you really need to do this? It's just asking for trouble.
It can assign a init MAC address to the port.
Now, EEPROM issue is solved. We can remove it.
CONFIG_TULIP is not accurate for the port. I have
renamed it to CONFIG_ULI526X in the driver.
I will provide a patch to fix both of these.
Tired today :-), hope tomorrow!
Thanks.
Roy
next prev parent reply other threads:[~2007-11-14 11:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 18:49 [U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config Jon Loeliger
2007-11-13 21:37 ` Ben Warren
2007-11-14 11:47 ` Zang Roy-r61911 [this message]
2007-11-14 15:09 ` Ben Warren
2007-11-14 15:27 ` Timur Tabi
2007-11-14 15:54 ` Jon Loeliger
2007-11-14 16:04 ` Timur Tabi
2007-11-14 16:09 ` Jon Loeliger
2007-11-14 16:30 ` Stefan Roese
2007-11-14 16:40 ` Timur Tabi
2007-11-15 10:30 ` Zang Roy-r61911
2007-11-15 14:03 ` Timur Tabi
2007-11-15 18:02 ` Scott Wood
2007-11-15 18:05 ` Timur Tabi
2007-11-16 6:14 ` Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195040831.3571.7.camel@localhost.localdomain \
--to=tie-fei.zang@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox