public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH 1/8] common: Suppress the warning 'p_buf'
@ 2008-01-10 15:01 Dave Liu
  2008-01-11  4:01 ` Kim Phillips
  0 siblings, 1 reply; 4+ messages in thread
From: Dave Liu @ 2008-01-10 15:01 UTC (permalink / raw)
  To: u-boot

clear the warning: unused variable 'p_buf'

Signed-off-by: Dave Liu <daveliu@freescale.com>
---
 common/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/main.c b/common/main.c
index ad2a386..4687c83 100644
--- a/common/main.c
+++ b/common/main.c
@@ -924,7 +924,6 @@ int readline (const char *const prompt)
 int readline_into_buffer (const char *const prompt, char * buffer)
 {
 	char *p = buffer;
-	char * p_buf = p;
 #ifdef CONFIG_CMDLINE_EDITING
 	unsigned int len=MAX_CMDBUF_SIZE;
 	int rc;
@@ -940,6 +939,7 @@ int readline_into_buffer (const char *const prompt, char * buffer)
 	rc = cread_line(prompt, p, &len);
 	return rc < 0 ? rc : len;
 #else
+	char *p_buf = p;
 	int	n = 0;				/* buffer index		*/
 	int	plen = 0;			/* prompt length	*/
 	int	col;				/* output column cnt	*/
-- 
1.5.3.5.643.g40e25

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot-Users] [PATCH 1/8] common: Suppress the warning 'p_buf'
  2008-01-10 15:01 [U-Boot-Users] [PATCH 1/8] common: Suppress the warning 'p_buf' Dave Liu
@ 2008-01-11  4:01 ` Kim Phillips
  2008-01-11  5:04   ` Liu Dave
  2008-01-12  2:33   ` Liu Dave
  0 siblings, 2 replies; 4+ messages in thread
From: Kim Phillips @ 2008-01-11  4:01 UTC (permalink / raw)
  To: u-boot

On Thu, 10 Jan 2008 23:01:53 +0800
Dave Liu <r63238@freescale.com> wrote:

> clear the warning: unused variable 'p_buf'
> 
> Signed-off-by: Dave Liu <daveliu@freescale.com>
> ---
>  common/main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

applied 2 through 8 out of 8, since Kumar beat you to this p_buf patch
(and is in common/ anyway, so it's for WD to apply directly).

Kim

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot-Users] [PATCH 1/8] common: Suppress the warning 'p_buf'
  2008-01-11  4:01 ` Kim Phillips
@ 2008-01-11  5:04   ` Liu Dave
  2008-01-12  2:33   ` Liu Dave
  1 sibling, 0 replies; 4+ messages in thread
From: Liu Dave @ 2008-01-11  5:04 UTC (permalink / raw)
  To: u-boot

So, Wolfgang, please apply the patch to your tree directly.

Thanks,
Dave 

> -----Original Message-----
> From: Phillips Kim 
> Sent: 2008?1?11? 12:02 PM
> To: Liu Dave
> Cc: Wolfgang Denk; u-boot-external
> Subject: Re: [PATCH 1/8] common: Suppress the warning 'p_buf'
> 
> On Thu, 10 Jan 2008 23:01:53 +0800
> Dave Liu <r63238@freescale.com> wrote:
> 
> > clear the warning: unused variable 'p_buf'
> > 
> > Signed-off-by: Dave Liu <daveliu@freescale.com>
> > ---
> >  common/main.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> applied 2 through 8 out of 8, since Kumar beat you to this p_buf patch
> (and is in common/ anyway, so it's for WD to apply directly).
> 
> Kim
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot-Users] [PATCH 1/8] common: Suppress the warning 'p_buf'
  2008-01-11  4:01 ` Kim Phillips
  2008-01-11  5:04   ` Liu Dave
@ 2008-01-12  2:33   ` Liu Dave
  1 sibling, 0 replies; 4+ messages in thread
From: Liu Dave @ 2008-01-12  2:33 UTC (permalink / raw)
  To: u-boot

> > clear the warning: unused variable 'p_buf'
> > 
> > Signed-off-by: Dave Liu <daveliu@freescale.com>
> > ---
> >  common/main.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> applied 2 through 8 out of 8, since Kumar beat you to this p_buf patch
> (and is in common/ anyway, so it's for WD to apply directly).

Sorry for that, I didn't notice Kumar's patch for it.

Dave

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-01-12  2:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-10 15:01 [U-Boot-Users] [PATCH 1/8] common: Suppress the warning 'p_buf' Dave Liu
2008-01-11  4:01 ` Kim Phillips
2008-01-11  5:04   ` Liu Dave
2008-01-12  2:33   ` Liu Dave

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox