From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/6] pinctrl: mscc: Add gpio and pinctrl for Jaguar2 SOC family
Date: Thu, 10 Jan 2019 17:56:56 +0100 [thread overview]
Message-ID: <11b1b31a-4976-3c38-e2f3-5f609db87a73@gmail.com> (raw)
In-Reply-To: <87ef9kob55.fsf@FE-laptop>
Hi Horatio,
Am 10.01.19 um 15:11 schrieb Gregory CLEMENT:
> Hi Horatiu,
>
> On jeu., janv. 10 2019, Horatiu Vultur <horatiu.vultur@microchip.com> wrote:
>
>> The Jaguar2 SOC family has 63 gpio pins therefore I extended mscc-common
>> to support new numbe of pins and remove any platform dependency from
>> mscc-common.
>>
>> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>> ---
>> MAINTAINERS | 1 +
>> drivers/pinctrl/mscc/Kconfig | 9 +
>> drivers/pinctrl/mscc/Makefile | 1 +
>> drivers/pinctrl/mscc/mscc-common.c | 90 +++++++---
>> drivers/pinctrl/mscc/mscc-common.h | 17 +-
>> drivers/pinctrl/mscc/pinctrl-jr2.c | 315 ++++++++++++++++++++++++++++++++++
>> drivers/pinctrl/mscc/pinctrl-luton.c | 16 +-
>> drivers/pinctrl/mscc/pinctrl-ocelot.c | 16 +-
>> 8 files changed, 436 insertions(+), 29 deletions(-)
>> create mode 100644 drivers/pinctrl/mscc/pinctrl-jr2.c
>>
this series looks now good to me but you should address Gregory's
comments. I didn't review the device-trees in detail as I expected that
you use the Linux versions which already had a proper review.
--
- Daniel
next prev parent reply other threads:[~2019-01-10 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 8:06 [U-Boot] [PATCH v4 0/6] MSCC: Add Jaguar2 SOC family Horatiu Vultur
2019-01-10 8:06 ` [U-Boot] [PATCH v4 1/6] pinctrl: mscc: Add gpio and pinctrl for " Horatiu Vultur
2019-01-10 14:11 ` Gregory CLEMENT
2019-01-10 16:56 ` Daniel Schwierzeck [this message]
2019-01-10 8:06 ` [U-Boot] [PATCH v4 2/6] MSCC: Add support " Horatiu Vultur
2019-01-10 8:06 ` [U-Boot] [PATCH v4 3/6] MSCC: Add device tree for Jaguar2 board Horatiu Vultur
2019-01-10 8:06 ` [U-Boot] [PATCH v4 4/6] MSCC: Add device tree for Jaguar2-48 board Horatiu Vultur
2019-01-10 8:06 ` [U-Boot] [PATCH v4 5/6] MSCC: add device tree for Serval2 board Horatiu Vultur
2019-01-10 8:06 ` [U-Boot] [PATCH v4 6/6] MSCC: Add board support for Jaguar2 SOC family Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11b1b31a-4976-3c38-e2f3-5f609db87a73@gmail.com \
--to=daniel.schwierzeck@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox