[U-Boot-Users] [PATCH] QE: fix compile warning

[U-Boot-Users] [PATCH] QE: fix compile warning

[Dave Liu]

qe.c: In function 'qe_upload_firmware':
qe.c:390: warning: pointer targets in passing argument 2
uec.c: In function 'uec_initialize':
uec.c:1236: warning: 'uec_info' may be used uninitialized

Signed-off-by: Dave Liu <daveliu@freescale.com>
---
 drivers/qe/qe.c  |    2 +-
 drivers/qe/uec.c |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c
index c802014..63acfa3 100644
--- a/drivers/qe/qe.c
+++ b/drivers/qe/qe.c
@@ -387,7 +387,7 @@ int qe_upload_firmware(const struct qe_firmware *firmware)
 	 * saved microcode information and put in the new.
 	 */
 	memset(&qe_firmware_info, 0, sizeof(qe_firmware_info));
-	strcpy(qe_firmware_info.id, firmware->id);
+	strcpy(qe_firmware_info.id, (char *)firmware->id);
 	qe_firmware_info.extended_modes = firmware->extended_modes;
 	memcpy(qe_firmware_info.vtraps, firmware->vtraps,
 		sizeof(firmware->vtraps));
diff --git a/drivers/qe/uec.c b/drivers/qe/uec.c
index 44cbea5..6cb25bf 100644
--- a/drivers/qe/uec.c
+++ b/drivers/qe/uec.c
@@ -1249,6 +1249,7 @@ int uec_initialize(int index)
 	memset(uec, 0, sizeof(uec_private_t));
 
 	/* Init UEC private struct, they come from board.h */
+	uec_info = NULL;
 	if (index == 0) {
 #ifdef CONFIG_UEC_ETH1
 		uec_info = &eth1_uec_info;
-- 
1.5.3.5.643.g40e25

[U-Boot-Users] [PATCH] QE: fix compile warning

[Wolfgang Denk]

In message <1200280321.3654.1.camel@localhost.localdomain> you wrote:
> qe.c: In function 'qe_upload_firmware':
> qe.c:390: warning: pointer targets in passing argument 2
> uec.c: In function 'uec_initialize':
> uec.c:1236: warning: 'uec_info' may be used uninitialized
> 
> Signed-off-by: Dave Liu <daveliu@freescale.com>

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
After a time, you may find that "having" is not so pleasing a thing,
after all, as "wanting."  It is not logical, but it is often true.
	-- Spock, "Amok Time", stardate 3372.7