public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] pcmcia: Remove CONFIG_COMMANDS from	marubun pcmcia driver
Date: Tue, 15 Jan 2008 13:34:21 -0600	[thread overview]
Message-ID: <1200425660.14540.18.camel@ld0161-tx32> (raw)
In-Reply-To: <20080116024624.35b534ba.iwamatsu@nigauri.org>

On Tue, 2008-01-15 at 11:46, Nobuhiro Iwamatsu wrote:
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
>  drivers/pcmcia/marubun_pcmcia.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pcmcia/marubun_pcmcia.c b/drivers/pcmcia/marubun_pcmcia.c
> index 7b112af..2479a66 100644
> --- a/drivers/pcmcia/marubun_pcmcia.c
> +++ b/drivers/pcmcia/marubun_pcmcia.c
> @@ -25,11 +25,13 @@
>  #include <pcmcia.h>
>  #include <asm/io.h>
>  
> -#if	(CONFIG_COMMANDS & CFG_CMD_PCMCIA)
> +#undef CONFIG_PCMCIA
> +
> +#if defined(CONFIG_CMD_PCMCIA)
>  #define	CONFIG_PCMCIA
>  #endif
>  
> -#if	(CONFIG_COMMANDS & CFG_CMD_IDE)
> +#if	defined(CONFIG_CMD_IDE)
>  #define	CONFIG_PCMCIA
>  #endif
>  

Amen-brother-by: Jon Loeliger <jdl@freescale.com>


Oh, and, a "git grep CONFIG_COMMANDS" reveals that there
are a few other lingering instances of this bug around.

jdl

  reply	other threads:[~2008-01-15 19:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15 17:46 [U-Boot-Users] [PATCH] pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver Nobuhiro Iwamatsu
2008-01-15 19:34 ` Jon Loeliger [this message]
2008-01-17  9:25   ` Nobuhiro Iwamatsu
2008-01-17 14:50     ` Jon Loeliger
2008-01-17 15:03       ` Ben Warren
2008-01-18 13:56       ` Nobuhiro Iwamatsu
2008-01-18 14:47         ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200425660.14540.18.camel@ld0161-tx32 \
    --to=jdl@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox