From: Stelian Pop <stelian@popies.net>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 4/5] [ARM] AT91CAP9 support - board/ files
Date: Mon, 28 Jan 2008 11:49:00 +0100 [thread overview]
Message-ID: <1201517340.5985.23.camel@galileo> (raw)
In-Reply-To: <20080127004829.83B7324792@gemini.denx.de>
Le dimanche 27 janvier 2008 ? 01:48 +0100, Wolfgang Denk a ?crit :
> In message <1201392141.17917.25.camel@galileo> you wrote:
> > AT91CAP9 support - board/ files
> >
> > Signed-off-by: Stelian Pop <stelian@popies.net>
> >
> > ---
> > board/at91cap9adk/Makefile | 50 +++++++
> > board/at91cap9adk/at91cap9adk.c | 275 +++++++++++++++++++++++++++++++++++++++
[...]
> There are coding style issues in this patch;
> indentation not by TAB in board/at91cap9adk/Makefile,
I could not found any coding style issues in this particular file...
> board/at91cap9adk/at91cap9adk.c and probably elsewhere
But yes, there were many coding style problems all over the place. To my
defense, a fair number of them were "imported" when I copied the files
from other places (atmel supplied files or even u-boot tree...). But
this is no excuse to not clean them before submitting new code.
I'm submitting a new version of the patches with hopefuly all coding
style issues resolved.
Stelian.
--
Stelian Pop <stelian@popies.net>
next prev parent reply other threads:[~2008-01-28 10:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 23:56 [U-Boot-Users] [PATCH 0/5] [ARM] AT91CAP9 support Stelian Pop
2008-01-26 23:59 ` [U-Boot-Users] [PATCH 1/5] [ARM] AT91CAP9 support - build files Stelian Pop
2008-01-27 0:00 ` [U-Boot-Users] [PATCH 2/5] [ARM] AT91CAP9 support - include/ files Stelian Pop
2008-01-27 0:51 ` Wolfgang Denk
2008-01-27 0:01 ` [U-Boot-Users] [PATCH 3/5] [ARM] AT91CAP9 support - cpu/ files Stelian Pop
2008-01-27 0:02 ` [U-Boot-Users] [PATCH 4/5] [ARM] AT91CAP9 support - board/ files Stelian Pop
2008-01-27 0:48 ` Wolfgang Denk
2008-01-28 10:49 ` Stelian Pop [this message]
2008-01-27 0:03 ` [U-Boot-Users] [PATCH 5/5] [ARM] AT91CAP9 support - macb changes Stelian Pop
2008-01-27 0:49 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2008-01-28 10:51 [U-Boot-Users] [PATCH 0/5] [ARM] AT91CAP9 support Stelian Pop
2008-01-28 10:57 ` [U-Boot-Users] [PATCH 4/5] [ARM] AT91CAP9 support - board/ files Stelian Pop
2008-01-28 21:26 ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-29 9:03 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201517340.5985.23.camel@galileo \
--to=stelian@popies.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox