From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stelian Pop Date: Fri, 01 Feb 2008 21:48:50 +0100 Subject: [U-Boot-Users] [PATCH 3/5] AT91CAP9 support : cpu/ files In-Reply-To: <000801c864a2$3c115eb0$060514ac@atmel.com> References: <1201814156-15777-1-git-send-email-stelian@popies.net> <1201814156-15777-4-git-send-email-stelian@popies.net> <000801c864a2$3c115eb0$060514ac@atmel.com> Message-ID: <1201898930.7645.13.camel@galileo> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le vendredi 01 f?vrier 2008 ? 00:24 +0100, Ulf Samuelsson a ?crit : > > Signed-off-by: Stelian Pop > > --- > > cpu/arm926ejs/at91cap9/Makefile | 46 ++++++++++ > > cpu/arm926ejs/at91cap9/config.mk | 2 + > > cpu/arm926ejs/at91cap9/ether.c | 35 ++++++++ > > cpu/arm926ejs/at91cap9/lowlevel_init.S | 43 +++++++++ > > cpu/arm926ejs/at91cap9/spi.c | 119 +++++++++++++++++++++++++ > > cpu/arm926ejs/at91cap9/timer.c | 149 ++++++++++++++++++++++++++++++++ > > cpu/arm926ejs/at91cap9/usb.c | 54 ++++++++++++ > > cpu/arm926ejs/interrupts.c | 2 +- > > cpu/arm926ejs/start.S | 3 + > > How much is different from the Atmel AT91SAM926x U-Boot patches on www.linux4sam.org? Quite different. The AT91SAM926x U-Boot patches are against u-boot-1.1.5 uses a lot of "local" drivers, whereas the AT91CAP9 port reuses the existing in-tree drivers where possible (for ethernet, NOR flash, etc) > The CAP9 is very similar to the AT91SAM9263. Yes, it is. > Should those chips share drivers? They do, but those drivers are also common to other cpus (the ethernet is also used by avr32). So the place for those drivers is under drivers/ more than in a common at91cap/sam cpu/ directory. > Then it would be better to store the files in "cpu/arm926ejs/at91sam926x" Maybe. Or maybe the whole cpu/ separation should be rethink (for example, if a port for the AT91CAP7 - which very similar to the AT91CAP9 except for the ARM7TDMI core - is to be done, where should it go ? Maybe the cpu and the soc elements should be separated. Stelian. -- Stelian Pop