[U-Boot-Users] [PATCH 4/5] AT91CAP9 support : board/ files

Stefan Roese
2008-02-02T05:59:35Z

On Friday 01 February 2008, Stelian Pop wrote:
> Le jeudi 31 janvier 2008 ? 23:59 +0100, Ulf Samuelsson a ?crit :
> > > Signed-off-by: Stelian Pop <stelian@popies.net>
> > > ---
> > > board/at91cap9adk/Makefile | 50 +++++++
> > > board/at91cap9adk/at91cap9adk.c | 283
> > > +++++++++++++++++++++++++++++++++++++++ board/at91cap9adk/config.mk
> > > | 1 +
> > > board/at91cap9adk/led.c | 80 +++++++++++
> > > board/at91cap9adk/nand.c | 71 ++++++++++
> > > board/at91cap9adk/u-boot.lds | 57 ++++++++
> >
> > I think it would be better if these files were located in the
> > "board/atmel/at91cap9adk", instead of "board/at91cap9adk"
>
> I did think of that. I have no strong feeling about that. Except that if
> we put at91cap9adk under board/atmel, at91rm9200dk should go there too.

Right. I always prefer to "collect" board ports from one manufacturer/brand
into a specific directory. This way the board directory doesn't
get "polluted" that much. So it would be good if you could provide another
patch to move all existing Atmel ports into the board/atmel directory which
already exists.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================