From: Daniel Mack <daniel@caiaq.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] add support for Toradex Colibri module
Date: Wed, 13 Feb 2008 13:46:53 +0100 [thread overview]
Message-ID: <1202906813.6976.2.camel@omuntu> (raw)
In-Reply-To: <20080203230748.3346524308@gemini.denx.de>
Hi Wolfgang,
thanks for your response.
On Mon, 2008-02-04 at 00:07 +0100, Wolfgang Denk wrote:
> There are coding style issues with your patch: trailing white space,
> C++ comments, indentation not by multiples of 8 characters.
>
> Please clean up and resubmit.
>
> And while you are at it - please keep lists sorted (MAKEALL,
> Makefile).
Ok, done. New, refurbished patch is attached.
Thanks and best regards,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uboot-131-colibri.diff
Type: text/x-patch
Size: 27093 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080213/b45e9743/attachment.bin
next prev parent reply other threads:[~2008-02-13 12:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 21:38 [U-Boot-Users] [PATCH] add support for Toradex Colibri module Daniel Mack
2007-11-30 22:09 ` Jean-Christophe PLAGNIOL-VILLARD
2007-11-30 23:13 ` Daniel Mack
2008-01-12 8:27 ` Daniel Mack
2008-01-23 15:06 ` Daniel Mack
2008-01-23 20:55 ` Wolfgang Denk
2008-02-03 23:07 ` Wolfgang Denk
2008-02-13 12:46 ` Daniel Mack [this message]
2008-04-13 22:01 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202906813.6976.2.camel@omuntu \
--to=daniel@caiaq.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox