From: Wolfgang Denk <wd@denx.de>
To: Simon Glass <sjg@chromium.org>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
"Eugeniu Rosca" <erosca@de.adit-jv.com>,
"Roland Gaudig" <roland.gaudig@weidmueller.com>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Stefan Herbrechtsmeier" <stefan.herbrechtsmeier@weidmueller.com>,
"Sean Anderson" <seanga2@gmail.com>,
"Marek Behún" <marek.behun@nic.cz>,
"Tom Rini" <trini@konsulko.com>, "Marek Vasut" <marex@denx.de>
Subject: Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y
Date: Sat, 24 Jul 2021 15:00:19 +0200 [thread overview]
Message-ID: <1204917.1627131619@gemini.denx.de> (raw)
In-Reply-To: <CAPnjgZ0B0oyxn8enY4dKNmGYJtF-vr9tYXzaBahLDt70Wz6axA@mail.gmail.com>
Dear Simon,
In message <CAPnjgZ0B0oyxn8enY4dKNmGYJtF-vr9tYXzaBahLDt70Wz6axA@mail.gmail.com> you wrote:
>
> > > There are quite a few places where simple_strtoul() is called with a
> > > base of 0. In that case, if the string starts with 0 it is interpreted
> > > as octal.
> >
> > That's a bug, then.
>
> If so it is a 19-year-old bug: (was lib_generic/vsprintc.c)
>
> 153d511e369 Initial revision
Mea culpa.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
The trouble with our times is that the future is not what it used to
be. - Paul Valery
next prev parent reply other threads:[~2021-07-24 13:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 13:29 [PATCH 00/15] lib: Add support for a decimal 0m prefix for numbers Simon Glass
2021-07-20 13:29 ` [PATCH 01/15] hash: Ensure verification hex pairs are terminated Simon Glass
2021-07-20 13:29 ` [PATCH 02/15] global: Convert simple_strtoul() with hex to hextoul() Simon Glass
2021-07-20 13:29 ` [PATCH 03/15] global: Convert simple_strtoul() with decimal to dectoul() Simon Glass
2021-07-20 13:29 ` [PATCH 04/15] lib: Comment the base parameter with simple_strtoul/l() Simon Glass
2021-07-20 13:29 ` [PATCH 05/15] lib: Drop unnecessary check for hex digit Simon Glass
2021-07-20 13:29 ` [PATCH 06/15] lib: Add tests for simple_strtoull() Simon Glass
2021-07-20 13:29 ` [PATCH 07/15] lib: Add octal tests for simple_strtoul/l() Simon Glass
2021-07-20 13:29 ` [PATCH 08/15] lib: Move common digit-parsing code into a function Simon Glass
2021-07-20 13:29 ` [PATCH 09/15] doc: Convert command-line info to rST Simon Glass
2021-07-20 13:29 ` [PATCH 10/15] doc: Add a note about number representation Simon Glass
2021-07-20 13:29 ` [PATCH 11/15] lib: Allow using 0x when a decimal value is requested Simon Glass
2021-07-20 13:29 ` [PATCH 12/15] lib: Support a decimal prefix 0m Simon Glass
2021-07-20 13:29 ` [PATCH 13/15] RFC: lib: Support a binary prefix 0y Simon Glass
2021-07-21 8:05 ` Sean Anderson
2021-07-21 8:30 ` Wolfgang Denk
2021-07-21 8:27 ` Wolfgang Denk
2021-07-21 14:23 ` Simon Glass
2021-07-22 9:48 ` Wolfgang Denk
2021-07-22 13:28 ` Simon Glass
2021-07-22 14:44 ` Tom Rini
2021-07-23 3:07 ` Simon Glass
2021-07-23 6:55 ` Wolfgang Denk
2021-07-23 21:41 ` Simon Glass
2021-07-24 13:00 ` Wolfgang Denk [this message]
2021-07-20 13:29 ` [PATCH 14/15] RFC: lib: Use 0o prefix for octal Simon Glass
2021-07-20 13:29 ` [PATCH 15/15] RFC: Change simple_strtoul() et al to default to hex Simon Glass
2021-07-20 14:22 ` [PATCH 00/15] lib: Add support for a decimal 0m prefix for numbers Tom Rini
2021-07-20 15:57 ` Simon Glass
2021-07-20 16:05 ` Tom Rini
2021-07-20 16:30 ` Eugeniu Rosca
2021-07-20 18:33 ` Simon Glass
2021-07-20 19:28 ` Tom Rini
2021-07-21 13:57 ` Simon Glass
2021-07-21 7:52 ` Wolfgang Denk
2021-07-21 14:46 ` Simon Glass
2021-07-23 21:41 ` Simon Glass
2021-07-20 15:00 ` Jonathan A. Kollasch
2021-07-20 15:04 ` Tom Rini
2021-07-21 7:42 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204917.1627131619@gemini.denx.de \
--to=wd@denx.de \
--cc=erosca@de.adit-jv.com \
--cc=marek.behun@nic.cz \
--cc=marex@denx.de \
--cc=roland.gaudig@weidmueller.com \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=stefan.herbrechtsmeier@weidmueller.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox