public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dave Liu <r63238@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Merge code duplication in ata.h and	libata.h
Date: Mon, 31 Mar 2008 14:45:48 +0800	[thread overview]
Message-ID: <1206945948.3679.2.camel@localhost.localdomain> (raw)
In-Reply-To: <1206945359-9555-1-git-send-email-tor@excito.com>


> -       fsl_sata_exec_cmd(sata, cfis, CMD_ATA, 0, buffer,
> ATA_SECT_SIZE * blkcnt);
> +       fsl_sata_exec_cmd(sata, cfis, CMD_ATA, 0, buffer,
> ATA_SECT_BYTESIZE * blkcnt);
>         return blkcnt;
>  }
> 
> @@ -658,7 +659,7 @@ static u32 fsl_sata_rw_cmd_ext(int dev, u32 start,
> u32 blkcnt, u8 *buffer, int i
>         cfis->sector_count_exp = (blkcnt >> 8) & 0xff;
>         cfis->sector_count = blkcnt & 0xff;
> 
> -       fsl_sata_exec_cmd(sata, cfis, CMD_ATA, 0, buffer,
> ATA_SECT_SIZE * blkcnt);
> +       fsl_sata_exec_cmd(sata, cfis, CMD_ATA, 0, buffer,
> ATA_SECT_BYTESIZE * blkcnt);
>         return blkcnt;


Nack.

Don't do this.

I don't think the ATA_SECT_BYTESIZE is better than
the ATA_SECT_SIZE.

The libata.h is closely than the latest linux kernel.

  reply	other threads:[~2008-03-31  6:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-31  6:35 [U-Boot-Users] [PATCH] Merge code duplication in ata.h and libata.h Tor Krill
2008-03-31  6:45 ` Dave Liu [this message]
2008-03-31  8:20   ` Tor Krill
2008-03-31  7:37     ` Dave Liu
2008-03-31  9:10       ` Tor Krill
2008-03-31  8:40         ` Dave Liu
2008-03-31 10:45     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1206945948.3679.2.camel@localhost.localdomain \
    --to=r63238@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox