From: Dave Liu <r63238@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Merge code duplication in ata.h and libata.h
Date: Mon, 31 Mar 2008 15:37:49 +0800 [thread overview]
Message-ID: <1206949069.3662.8.camel@localhost.localdomain> (raw)
In-Reply-To: <MdNGBCPY.1206951652.2688260.tor@localhost>
> >Don't do this.
> >
> >I don't think the ATA_SECT_BYTESIZE is better than
> >the ATA_SECT_SIZE.
>
> The big problem here is that ata.h defines ATA_SECT_SIZE as 256 Words
> where libata defines it as 512 Bytes.
>
> I did not want to change the old define since it would possibly break
> more than the fsl driver.
When I grep 'ATA_SECT_SIZE', I can *not* find any files including the
ATA_SECT_SIZE before the fsl_sata.c.
> But the problem still remains, it is currently impossible to use both
> libata.h and ata.h.
Why need use both them?
I believe the libata.h is enough.
If the libata.h is not enough for you, I suggest you update it from the
latest linux kernel.
I think it is correct way to handle it.
It will be more easy to to maintain the header.
next prev parent reply other threads:[~2008-03-31 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-31 6:35 [U-Boot-Users] [PATCH] Merge code duplication in ata.h and libata.h Tor Krill
2008-03-31 6:45 ` Dave Liu
2008-03-31 8:20 ` Tor Krill
2008-03-31 7:37 ` Dave Liu [this message]
2008-03-31 9:10 ` Tor Krill
2008-03-31 8:40 ` Dave Liu
2008-03-31 10:45 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206949069.3662.8.camel@localhost.localdomain \
--to=r63238@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox