From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Liu Date: Mon, 31 Mar 2008 15:37:49 +0800 Subject: [U-Boot-Users] [PATCH] Merge code duplication in ata.h and libata.h In-Reply-To: References: Message-ID: <1206949069.3662.8.camel@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > >Don't do this. > > > >I don't think the ATA_SECT_BYTESIZE is better than > >the ATA_SECT_SIZE. > > The big problem here is that ata.h defines ATA_SECT_SIZE as 256 Words > where libata defines it as 512 Bytes. > > I did not want to change the old define since it would possibly break > more than the fsl driver. When I grep 'ATA_SECT_SIZE', I can *not* find any files including the ATA_SECT_SIZE before the fsl_sata.c. > But the problem still remains, it is currently impossible to use both > libata.h and ata.h. Why need use both them? I believe the libata.h is enough. If the libata.h is not enough for you, I suggest you update it from the latest linux kernel. I think it is correct way to handle it. It will be more easy to to maintain the header.