public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stelian Pop <stelian@popies.net>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add support for AT91RM9200EK board
Date: Sun, 13 Apr 2008 15:35:05 +0200	[thread overview]
Message-ID: <1208093705.23686.8.camel@voyager.dsnet> (raw)
In-Reply-To: <1208030816.23686.13.camel@elrond.atmel.sweden>


Le samedi 12 avril 2008 ? 22:06 +0200, Ulf Samuelsson a ?crit :
> Add support for the AT91RM9200EK Board.

Hi Ulf,

I do have a few issues with your patch. As you have seen, I started
adapting the Atmel changes for the AT91SAM boards, and in doing so I
tried to implement (well, quite a lot was borrowed from Linux) a common
infrastructure for the SAM9 and CAP9 CPUs/boards.

I think that the AT91RM9200 could integrate quite well in the existing
framework. I haven't done the job myself yet because I have quite
limited ressources at the moment (and this is why I chose
'arch-at91sam9' instead of 'arch-at91'...) but since you're contributing
a new port it may be the right time to do it.

This means for example:
	- using at91 gpio macros: at91_set_A_periph(), etc.
	- using the standard CFI flash driver instead of the custom one
	- maybe others...

Ah, and it would be much easier to quote and comment on your patches if
they were inlined in your mails.

Thanks,

Stelian.
-- 
Stelian Pop <stelian@popies.net>

  reply	other threads:[~2008-04-13 13:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-12 20:06 [U-Boot-Users] [PATCH] Add support for AT91RM9200EK board Ulf Samuelsson
2008-04-13 13:35 ` Stelian Pop [this message]
2008-04-14  6:01   ` Ulf Samuelsson
2008-04-14  9:16     ` Stelian Pop
2008-04-14 13:26 ` Jean-Christophe PLAGNIOL-VILLARD
2008-04-14 19:50 ` Wolfgang Denk
2008-04-15  7:58   ` Ulf Samuelsson
2008-04-15 16:23     ` Wolfgang Denk
2008-04-15 21:35       ` Ulf Samuelsson
2008-04-15 22:01         ` Stelian Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1208093705.23686.8.camel@voyager.dsnet \
    --to=stelian@popies.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox