From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] lwmon5 watchdog: limit trigger rate
Date: Tue, 22 Apr 2008 16:24:52 +0200 [thread overview]
Message-ID: <1208874293-2123-11-git-send-email-wd@denx.de> (raw)
In-Reply-To: <1208874293-2123-10-git-send-email-wd@denx.de>
From: Yuri Tikhonov <yur@emcraft.com>
Limit the rate of h/w watch-dog triggering on the LWMON5 board by
the CONFIG_WD_MAX_RATE value.
Note that an earlier version of this patch which used microseconds
instead of ticks dis not work. The problem was that we used
usec2ticks() to convert microseconds into ticks. usec2ticks() uses
get_tbclk(), which in turn calls get_sys_info(). It turns out that
this function does a lot of prolonged operations (like divisions)
which take too much time so we do not trigger the watchdog in time,
and it resets the system.
Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
---
board/lwmon5/lwmon5.c | 18 ++++++++++++++++++
include/asm-ppc/global_data.h | 3 +++
include/configs/lwmon5.h | 1 +
3 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/board/lwmon5/lwmon5.c b/board/lwmon5/lwmon5.c
index e5fa259..b63fbdc 100644
--- a/board/lwmon5/lwmon5.c
+++ b/board/lwmon5/lwmon5.c
@@ -476,6 +476,24 @@ int is_pci_host(struct pci_controller *hose)
void hw_watchdog_reset(void)
{
int val;
+#if defined(CONFIG_WD_MAX_RATE)
+ unsigned long long ct = get_ticks();
+
+ /*
+ * Don't allow watch-dog triggering more frequently than
+ * the predefined value CONFIG_WD_MAX_RATE [ticks].
+ */
+ if (ct >= gd->wdt_last) {
+ if ((ct - gd->wdt_last) < CONFIG_WD_MAX_RATE)
+ return;
+ } else {
+ /* Time base counter had been reset */
+ if (((unsigned long long)(-1) - gd->wdt_last + ct) <
+ CONFIG_WD_MAX_RATE)
+ return;
+ }
+ gd->wdt_last = get_ticks();
+#endif
/*
* Toggle watchdog output
diff --git a/include/asm-ppc/global_data.h b/include/asm-ppc/global_data.h
index e07092b..4657604 100644
--- a/include/asm-ppc/global_data.h
+++ b/include/asm-ppc/global_data.h
@@ -155,6 +155,9 @@ typedef struct global_data {
#if defined(CONFIG_LWMON) || defined(CONFIG_LWMON5)
unsigned long kbd_status;
#endif
+#if defined(CONFIG_WD_MAX_RATE)
+ unsigned long long wdt_last; /* trace watch-dog triggering rate */
+#endif
void **jt; /* jump table */
} gd_t;
diff --git a/include/configs/lwmon5.h b/include/configs/lwmon5.h
index ced7ba6..58f078b 100644
--- a/include/configs/lwmon5.h
+++ b/include/configs/lwmon5.h
@@ -455,6 +455,7 @@
#define CONFIG_HW_WATCHDOG 1 /* Use external HW-Watchdog */
#define CONFIG_WD_PERIOD 40000 /* in usec */
+#define CONFIG_WD_MAX_RATE 66600 /* in ticks */
/*
* For booting Linux, the board info and command line data
--
1.5.4.2
next prev parent reply other threads:[~2008-04-22 14:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 14:24 [U-Boot-Users] [PATCH] Enable CODEC POST with CFG_POST_CODEC rather than with CFG_POST_DSP Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] The patch adds new POST tests for the Lwmon5 board Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] The patch introduces the CRITICAL feature of POST tests. If the test Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] Some fixes to dspic, fpga, and gdc post tests for lwmon5 Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] Add support for the lwmon5 board reset via GPIO58 Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] The patch introduces the alternative configuration of the log buffer for Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] Fix backlight in the lwmon5 POST Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] lwmon5: Fix register test logic to match the specific GDC h/w Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] POST: preparations for moving CONFIG_POST to Makefiles Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] POST: move " Wolfgang Denk
2008-04-22 14:24 ` Wolfgang Denk [this message]
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] Added watchdog triggering calls in the "mtest" test function Wolfgang Denk
2008-04-24 14:43 ` [U-Boot-Users] [PATCH] lwmon5 watchdog: limit trigger rate Stefan Roese
2008-04-24 14:50 ` [U-Boot-Users] [PATCH] lwmon5: Fix register test logic to match the specific GDC h/w Stefan Roese
2008-04-24 14:36 ` [U-Boot-Users] [PATCH] Fix backlight in the lwmon5 POST Stefan Roese
2008-04-24 14:35 ` [U-Boot-Users] [PATCH] Add support for the lwmon5 board reset via GPIO58 Stefan Roese
2008-04-24 14:34 ` [U-Boot-Users] [PATCH] Some fixes to dspic, fpga, and gdc post tests for lwmon5 Stefan Roese
2008-04-24 14:33 ` [U-Boot-Users] [PATCH] The patch adds new POST tests for the Lwmon5 board Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208874293-2123-11-git-send-email-wd@denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox