From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] lwmon5: Fix register test logic to match the specific GDC h/w.
Date: Tue, 22 Apr 2008 16:24:49 +0200 [thread overview]
Message-ID: <1208874293-2123-8-git-send-email-wd@denx.de> (raw)
In-Reply-To: <1208874293-2123-7-git-send-email-wd@denx.de>
From: Yuri Tikhonov <yur@pollux.denx.de>
Signed-off-by: Dmitry Rakhchev <rda@emcraft.com>
Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
---
post/board/lwmon5/gdc.c | 18 ++++++++++++------
1 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/post/board/lwmon5/gdc.c b/post/board/lwmon5/gdc.c
index 0e4f0fd..aa1eee0 100644
--- a/post/board/lwmon5/gdc.c
+++ b/post/board/lwmon5/gdc.c
@@ -35,7 +35,7 @@
DECLARE_GLOBAL_DATA_PTR;
-#define GDC_SCRATCH_REG 0xC1FF8008
+#define GDC_SCRATCH_REG 0xC1FF8044
#define GDC_VERSION_REG 0xC1FF8084
#define GDC_RAM_START 0xC0000000
#define GDC_RAM_END 0xC2000000
@@ -44,7 +44,7 @@ DECLARE_GLOBAL_DATA_PTR;
static int gdc_test_reg_one(uint value)
{
- int ret = 0;
+ int ret;
uint read_value;
/* write test pattern */
@@ -56,10 +56,9 @@ static int gdc_test_reg_one(uint value)
if (read_value != value) {
post_log("GDC SCRATCH test failed write %08X, read %08X\n",
value, read_value);
- ret = 1;
}
- return ret;
+ return (read_value != value);
}
/* Verify GDC, get memory size */
@@ -71,9 +70,16 @@ int gdc_post_test(int flags)
post_log("\n");
old_value = in_be32((void *)GDC_SCRATCH_REG);
- if (gdc_test_reg_one(0x55555555))
+ /*
+ * GPIOC2 register behaviour: the LIME graphics processor has a
+ * maximum of 5 GPIO ports that can be used in this hardware
+ * configuration. Thus only the bits for these 5 GPIOs can be
+ * activated in the GPIOC2 register. All other bits will always be
+ * read as zero.
+ */
+ if (gdc_test_reg_one(0x00150015))
ret = 1;
- if (gdc_test_reg_one(0xAAAAAAAA))
+ if (gdc_test_reg_one(0x000A000A))
ret = 1;
out_be32((void *)GDC_SCRATCH_REG, old_value);
--
1.5.4.2
next prev parent reply other threads:[~2008-04-22 14:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 14:24 [U-Boot-Users] [PATCH] Enable CODEC POST with CFG_POST_CODEC rather than with CFG_POST_DSP Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] The patch adds new POST tests for the Lwmon5 board Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] The patch introduces the CRITICAL feature of POST tests. If the test Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] Some fixes to dspic, fpga, and gdc post tests for lwmon5 Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] Add support for the lwmon5 board reset via GPIO58 Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] The patch introduces the alternative configuration of the log buffer for Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] Fix backlight in the lwmon5 POST Wolfgang Denk
2008-04-22 14:24 ` Wolfgang Denk [this message]
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] POST: preparations for moving CONFIG_POST to Makefiles Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] POST: move " Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] lwmon5 watchdog: limit trigger rate Wolfgang Denk
2008-04-22 14:24 ` [U-Boot-Users] [PATCH] Added watchdog triggering calls in the "mtest" test function Wolfgang Denk
2008-04-24 14:43 ` [U-Boot-Users] [PATCH] lwmon5 watchdog: limit trigger rate Stefan Roese
2008-04-24 14:50 ` [U-Boot-Users] [PATCH] lwmon5: Fix register test logic to match the specific GDC h/w Stefan Roese
2008-04-24 14:36 ` [U-Boot-Users] [PATCH] Fix backlight in the lwmon5 POST Stefan Roese
2008-04-24 14:35 ` [U-Boot-Users] [PATCH] Add support for the lwmon5 board reset via GPIO58 Stefan Roese
2008-04-24 14:34 ` [U-Boot-Users] [PATCH] Some fixes to dspic, fpga, and gdc post tests for lwmon5 Stefan Roese
2008-04-24 14:33 ` [U-Boot-Users] [PATCH] The patch adds new POST tests for the Lwmon5 board Stefan Roese
-- strict thread matches above, loose matches on Subject: below --
2008-03-18 21:12 [U-Boot-Users] [PATCH] Enable CODEC POST with CFG_POST_CODEC rather than with CFG_POST_DSP Wolfgang Denk
2008-03-18 21:12 ` [U-Boot-Users] [PATCH] The patch adds new POST tests for the Lwmon5 board Wolfgang Denk
2008-03-18 21:12 ` [U-Boot-Users] [PATCH] The patch introduces the CRITICAL feature of POST tests. If the test Wolfgang Denk
2008-03-18 21:12 ` [U-Boot-Users] [PATCH] Some fixes to dspic, fpga, and gdc post tests for lwmon5 Wolfgang Denk
2008-03-18 21:12 ` [U-Boot-Users] [PATCH] Add support for the lwmon5 board reset via GPIO58 Wolfgang Denk
2008-03-18 21:12 ` [U-Boot-Users] [PATCH] The patch introduces the alternative configuration of the log buffer for Wolfgang Denk
2008-03-18 21:12 ` [U-Boot-Users] [PATCH] Fix backlight in the lwmon5 POST Wolfgang Denk
2008-03-18 21:12 ` [U-Boot-Users] [PATCH] lwmon5: Fix register test logic to match the specific GDC h/w Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208874293-2123-8-git-send-email-wd@denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox