public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stelian Pop <stelian@popies.net>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 13/21] Remeber the	0013-Remeber-the-RAM-and-NAND-detected-sizes-for-later-di.patch
Date: Tue, 06 May 2008 22:10:17 +0200	[thread overview]
Message-ID: <1210104617.25356.54.camel@galileo> (raw)
In-Reply-To: <20080506192825.774FD247F5@gemini.denx.de>


Le mardi 06 mai 2008 ? 21:28 +0200, Wolfgang Denk a ?crit :
> In message <1210088022-25757-14-git-send-email-stelian@popies.net> you wrote:
> > 
> > Signed-off-by: Stelian Pop <stelian@popies.net>
> > ---
> >  include/asm-arm/u-boot.h |    4 ++++
> >  lib_arm/board.c          |   14 ++++++++------
> >  2 files changed, 12 insertions(+), 6 deletions(-)
> > 
> > diff --git a/include/asm-arm/u-boot.h b/include/asm-arm/u-boot.h
> > index c120312..dbfe2cf 100644
> > --- a/include/asm-arm/u-boot.h
> > +++ b/include/asm-arm/u-boot.h
> > @@ -48,10 +48,14 @@ typedef struct bd_info {
> >  	ulong start;
> >  	ulong size;
> >      } 			bi_dram[CONFIG_NR_DRAM_BANKS];
> > +    ulong		bi_dram_size;
> 
> Why would that be needed?  Isn't  adding  the  "size"  entries  above
> sufficient?

It is. But this addition is done once more in the LCD driver (see patch
14/21), so I thought it would be useful to remember the result.

But if you consider it's more costly to add 4 bytes in global data than
to do the addition again, I can change it back.

-- 
Stelian Pop <stelian@popies.net>

  reply	other threads:[~2008-05-06 20:10 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06 15:33 [U-Boot-Users] [PATCH ARM/AT91 0/20] AT91SAM/CAP patches for U-Boot 1.3.4 Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 01/21] AT91CAP9ADK: Handle 8 or 16 bit NAND Stelian Pop
2008-05-08 14:08   ` Jean-Christophe PLAGNIOL-VILLARD
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 02/21] AT91CAP9ADK: Normalize SPI timings Stelian Pop
2008-05-06 19:23   ` Ken.Fuchs at bench.com
2008-05-06 19:59     ` Stelian Pop
2008-05-08 14:11   ` Jean-Christophe PLAGNIOL-VILLARD
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 03/21] AT91CAP9ADK: Normalize BOOTARGS Stelian Pop
2008-05-06 19:21   ` Wolfgang Denk
2008-05-06 19:53     ` Stelian Pop
2008-05-08 14:13       ` Jean-Christophe PLAGNIOL-VILLARD
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 04/21] AT91CAP9ADK: Fix dataflash offsets in BOOTCMD Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 05/21] AT91SAM9260EK: Handle 8 or 16 bit NAND Stelian Pop
2008-05-08 14:09   ` Jean-Christophe PLAGNIOL-VILLARD
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 06/21] AT91SAM9260EK: Normalize SPI timings Stelian Pop
2008-05-08 14:09   ` Jean-Christophe PLAGNIOL-VILLARD
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 07/21] AT91SAM9260EK: Normalize BOOTARGS Stelian Pop
2008-05-08 14:09   ` Jean-Christophe PLAGNIOL-VILLARD
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 08/21] AT91SAM9260EK: Fix dataflash offsets in BOOTCMD Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 09/21] AT91SAM9261EK support Stelian Pop
2008-05-06 19:33   ` Wolfgang Denk
2008-05-06 20:18     ` Stelian Pop
2008-05-06 21:14       ` Wolfgang Denk
2008-05-06 21:24         ` Stelian Pop
2008-05-07  8:25           ` Remy Bohmer
2008-05-07  8:32             ` Stelian Pop
2008-05-07  9:11             ` Ulf Samuelsson
2008-05-09 20:54               ` Wolfgang Denk
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 10/21] AT91SAM9263EK support Stelian Pop
2008-05-06 19:41   ` Wolfgang Denk
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 11/21] AT91SAM9RLEK support Stelian Pop
2008-05-06 19:26   ` Wolfgang Denk
2008-05-06 20:04     ` Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 12/21] Make nand_init() return the detected NAND size Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 13/21] Remeber the RAM and NAND detected sizes for later display Stelian Pop
2008-05-06 19:28   ` Wolfgang Denk
2008-05-06 20:10     ` Stelian Pop [this message]
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 14/21] Add ATMEL LCD driver Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 15/21] AT91CAP9ADK: hook up the " Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 16/21] AT91SAM9261EK: " Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 17/21] AT91SAM9263EK: " Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 18/21] AT91SAM9RLEK: " Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 19/21] Use custom logo for Atmel boards Stelian Pop
2008-05-06 15:33 ` [U-Boot-Users] [PATCH 20/21] Support AT91CAP9 revC CPUs Stelian Pop
2008-05-06 15:35   ` [U-Boot-Users] [PATCH 21/21] Stelian Pop
2008-05-06 19:33   ` [U-Boot-Users] [PATCH 20/21] Support AT91CAP9 revC CPUs Wolfgang Denk
2008-05-06 19:34   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1210104617.25356.54.camel@galileo \
    --to=stelian@popies.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox