* [U-Boot-Users] Make ADS5121 out-of-tree compiling compatible
@ 2008-05-09 20:59 York Sun
2008-05-09 20:59 ` [U-Boot-Users] [PATCH] Make " York Sun
0 siblings, 1 reply; 5+ messages in thread
From: York Sun @ 2008-05-09 20:59 UTC (permalink / raw)
To: u-boot
Wolfgang,
Please review the following patch which fixes the out-of-tree compiling.
Regards,
York
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot-Users] [PATCH] Make out-of-tree compiling compatible
2008-05-09 20:59 [U-Boot-Users] Make ADS5121 out-of-tree compiling compatible York Sun
@ 2008-05-09 20:59 ` York Sun
2008-05-09 23:17 ` Wolfgang Denk
2008-05-09 23:22 ` Kumar Gala
0 siblings, 2 replies; 5+ messages in thread
From: York Sun @ 2008-05-09 20:59 UTC (permalink / raw)
To: u-boot
Signed-off-by: York Sun <yorksun@freescale.com>
---
board/ads5121/Makefile | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/board/ads5121/Makefile b/board/ads5121/Makefile
index 8ace8a1..9b675f7 100644
--- a/board/ads5121/Makefile
+++ b/board/ads5121/Makefile
@@ -23,9 +23,14 @@
include $(TOPDIR)/config.mk
+$(shell mkdir -p $(OBJTREE)/board/freescale/common)
+
LIB = $(obj)lib$(BOARD).a
-COBJS-y := $(BOARD).o ads5121_diu.o ../freescale/common/fsl_diu_fb.o ../freescale/common/fsl_logo_bmp.o
+COBJS-y := $(BOARD).o
+COBJS-y += ads5121_diu.o
+COBJS-y += ../freescale/common/fsl_diu_fb.o
+COBJS-y += ../freescale/common/fsl_logo_bmp.o
COBJS-$(CONFIG_PCI) += pci.o
COBJS := $(COBJS-y)
--
1.5.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot-Users] [PATCH] Make out-of-tree compiling compatible
2008-05-09 20:59 ` [U-Boot-Users] [PATCH] Make " York Sun
@ 2008-05-09 23:17 ` Wolfgang Denk
2008-05-12 19:36 ` York Sun
2008-05-09 23:22 ` Kumar Gala
1 sibling, 1 reply; 5+ messages in thread
From: Wolfgang Denk @ 2008-05-09 23:17 UTC (permalink / raw)
To: u-boot
In message <12103667861729-git-send-email-yorksun@freescale.com> you wrote:
>
> Signed-off-by: York Sun <yorksun@freescale.com>
> ---
> board/ads5121/Makefile | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/board/ads5121/Makefile b/board/ads5121/Makefile
> index 8ace8a1..9b675f7 100644
> --- a/board/ads5121/Makefile
> +++ b/board/ads5121/Makefile
> @@ -23,9 +23,14 @@
>
> include $(TOPDIR)/config.mk
>
> +$(shell mkdir -p $(OBJTREE)/board/freescale/common)
> +
> LIB = $(obj)lib$(BOARD).a
I'm missing some rule to remove that directory for "make clean" or
"make distclean" ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's a way out of any cage.
-- Captain Christopher Pike, "The Menagerie" ("The Cage"),
stardate unknown.
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot-Users] [PATCH] Make out-of-tree compiling compatible
2008-05-09 23:17 ` Wolfgang Denk
@ 2008-05-12 19:36 ` York Sun
0 siblings, 0 replies; 5+ messages in thread
From: York Sun @ 2008-05-12 19:36 UTC (permalink / raw)
To: u-boot
On Sat, 2008-05-10 at 01:17 +0200, Wolfgang Denk wrote:
> > include $(TOPDIR)/config.mk
> >
> > +$(shell mkdir -p $(OBJTREE)/board/freescale/common)
> > +
> > LIB = $(obj)lib$(BOARD).a
>
> I'm missing some rule to remove that directory for "make clean" or
> "make distclean" ?
>
No, you are not. You have the following in Makefile
distclean: clobber unconfig
rm -rf $(obj)*
endif
All temporary folders are removed.
I just resent you the v2 patch.
York
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot-Users] [PATCH] Make out-of-tree compiling compatible
2008-05-09 20:59 ` [U-Boot-Users] [PATCH] Make " York Sun
2008-05-09 23:17 ` Wolfgang Denk
@ 2008-05-09 23:22 ` Kumar Gala
1 sibling, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2008-05-09 23:22 UTC (permalink / raw)
To: u-boot
On Fri, 9 May 2008, York Sun wrote:
>
> Signed-off-by: York Sun <yorksun@freescale.com>
> ---
> board/ads5121/Makefile | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/board/ads5121/Makefile b/board/ads5121/Makefile
> index 8ace8a1..9b675f7 100644
> --- a/board/ads5121/Makefile
> +++ b/board/ads5121/Makefile
> @@ -23,9 +23,14 @@
>
> include $(TOPDIR)/config.mk
>
> +$(shell mkdir -p $(OBJTREE)/board/freescale/common)
> +
> LIB = $(obj)lib$(BOARD).a
>
> -COBJS-y := $(BOARD).o ads5121_diu.o ../freescale/common/fsl_diu_fb.o ../freescale/common/fsl_logo_bmp.o
> +COBJS-y := $(BOARD).o
> +COBJS-y += ads5121_diu.o
> +COBJS-y += ../freescale/common/fsl_diu_fb.o
> +COBJS-y += ../freescale/common/fsl_logo_bmp.o
> COBJS-$(CONFIG_PCI) += pci.o
>
> COBJS := $(COBJS-y)
Why don't you just define CONFIG_FSL_DIU_FB in the ads5121 config.h? Then
you don't have to build the common objects in this Makefile as
board/freescale/common/Makefile will handle them.
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-05-12 19:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-09 20:59 [U-Boot-Users] Make ADS5121 out-of-tree compiling compatible York Sun
2008-05-09 20:59 ` [U-Boot-Users] [PATCH] Make " York Sun
2008-05-09 23:17 ` Wolfgang Denk
2008-05-12 19:36 ` York Sun
2008-05-09 23:22 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox