From mboxrd@z Thu Jan  1 00:00:00 1970
From: York Sun <yorksun@freescale.com>
Date: Thu, 15 May 2008 16:21:09 -0500
Subject: [U-Boot-Users] [PATCH 1/1] Fix 8313ERDB board configuration
In-Reply-To: <482CA1FF.4090505@gmail.com>
References: <12108831871831-git-send-email-yorksun@freescale.com>
	<482CA1FF.4090505@gmail.com>
Message-ID: <1210886469.880.45.camel@laptop>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Ben,

On Thu, 2008-05-15 at 13:50 -0700, Ben Warren wrote:
> > -#ifdef CONFIG_HAS_ETH0
> >  #define CONFIG_ETHADDR		00:E0:0C:00:95:01
> > -#endif
> > -
> > -#ifdef CONFIG_HAS_ETH1
> >  #define CONFIG_ETH1ADDR		00:E0:0C:00:95:02
> > -#endif
> >   
> Please also remove the default MAC address assignments.

I think we need them, don't we?

> >  
> >  #define CONFIG_IPADDR		10.0.0.2
> >  #define CONFIG_SERVERIP		10.0.0.1
> >   
> While you're at it, putting default IP addresses is also pointless.

At least it tells you that you can put your address here. It doesn't
hurt.
And BTW, I want to make my patch as small as possible. I'll leave the
rest to the board maintainer.

York