From: Kenneth Johansson <kenneth@southpole.se>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Consolidates ADS5121 IO Pin configuration
Date: Thu, 29 May 2008 22:11:56 +0200 [thread overview]
Message-ID: <1212091916.2236.11.camel@localhost.localdomain> (raw)
In-Reply-To: <12120898413202-git-send-email-mmarx@silicontkx.com>
On Thu, 2008-05-29 at 15:37 -0400, Martha Marx wrote:
> Signed-off-by: Martha Marx <mmarx@silicontkx.com>
> ---
> board/ads5121/Makefile | 2 +-
> board/ads5121/ads5121.c | 36 +-------
> board/ads5121/iopin.c | 96 ++++++++++++++++++++
> board/ads5121/iopin.h | 220 +++++++++++++++++++++++++++++++++++++++++++++
> cpu/mpc512x/fec.c | 15 ---
> include/configs/ads5121.h | 1 +
> 6 files changed, 321 insertions(+), 49 deletions(-)
> create mode 100644 board/ads5121/iopin.c
> create mode 100644 board/ads5121/iopin.h
It's good that you remove iomux setting from the drivers like fec it
should not be there.
It's NOT good that you now put them in another "driver" iopin.
The pins should be in board specific files. iopin should only contain
helper functions not data that everybody that do a new board needs to go
in and change/add.
put the table in ads5121.c and I'm happy with it. well I'm not sure we
need this fancy stuff only gets harder to read but I take that over
having the config spread out over different files like it's now.
next prev parent reply other threads:[~2008-05-29 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 19:37 [U-Boot-Users] [PATCH] Consolidates ADS5121 IO Pin configuration Martha Marx
2008-05-29 20:11 ` Kenneth Johansson [this message]
2008-06-16 14:51 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212091916.2236.11.camel@localhost.localdomain \
--to=kenneth@southpole.se \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox